From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 34506 invoked by alias); 9 Mar 2018 03:57:18 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 34495 invoked by uid 89); 9 Mar 2018 03:57:18 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy=H*M:73f3 X-HELO: simark.ca Received: from simark.ca (HELO simark.ca) (158.69.221.121) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 09 Mar 2018 03:57:17 +0000 Received: from [10.0.0.11] (192-222-251-162.qc.cable.ebox.net [192.222.251.162]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 9A8CD1E03D; Thu, 8 Mar 2018 22:57:15 -0500 (EST) Subject: Re: [RFA] Change enable_thread_stack_temporaries to an RAII class To: Tom Tromey , gdb-patches@sourceware.org References: <20180308053543.18516-1-tom@tromey.com> From: Simon Marchi Message-ID: <8926b4ac-73f3-a7c8-3e7d-cebe3ec4f311@simark.ca> Date: Fri, 09 Mar 2018 03:57:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <20180308053543.18516-1-tom@tromey.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2018-03/txt/msg00185.txt.bz2 On 2018-03-08 12:35 AM, Tom Tromey wrote: > diff --git a/gdb/infcall.c b/gdb/infcall.c > index b7f4a176db..a77749f514 100644 > --- a/gdb/infcall.c > +++ b/gdb/infcall.c > @@ -411,7 +411,7 @@ struct call_return_meta_info > CORE_ADDR struct_addr; > > /* Whether stack temporaries are enabled. */ > - int stack_temporaries_enabled; > + bool stack_temporaries_enabled; I think we can just removed this field, it seems to be unused. Otherwise LGTM. Simon