From: Tom Tromey <tromey@redhat.com>
To: Marc Khouzam <marc.khouzam@ericsson.com>
Cc: "'gdb-patches\@sourceware.org'" <gdb-patches@sourceware.org>
Subject: Re: [Patch] Cannot set pending bp if condition set explicitly
Date: Wed, 25 Jul 2012 15:28:00 -0000 [thread overview]
Message-ID: <87zk6nkghi.fsf@fleche.redhat.com> (raw)
In-Reply-To: <F7CE05678329534C957159168FA70DEC5C24CAEA18@EUSAACMS0703.eamcs.ericsson.se> (Marc Khouzam's message of "Tue, 24 Jul 2012 10:45:10 -0400")
>>>>> "Marc" == Marc Khouzam <marc.khouzam@ericsson.com> writes:
Marc> If I set a condition explicitly on a pending breakpoint (using
Marc> the 'condition' command), the breakpoint fails to install.
Marc> + /* For a pending breakoint, the condition is not parsed yet */
Comment should end with a period and two spaces.
Marc> + if (b->loc == NULL || b->loc->shlib_disabled)
I think this ought to use all_locations_are_pending.
But, I am not 100% sure of this.
A test case for this would be quite nice to have.
Tom
next prev parent reply other threads:[~2012-07-25 15:28 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-24 14:45 Marc Khouzam
2012-07-25 15:28 ` Tom Tromey [this message]
2012-07-25 20:31 ` Marc Khouzam
2012-07-25 20:44 ` Tom Tromey
2012-07-26 19:05 ` Pedro Alves
2012-07-27 2:45 ` Marc Khouzam
2012-07-30 15:19 ` Pedro Alves
2012-07-30 15:36 ` Tom Tromey
2012-08-03 0:44 ` disable breakpoints with invalid condition (Re: [Patch] Cannot set pending bp if condition set explicitly) Pedro Alves
2012-08-03 0:51 ` [Patch] Cannot set pending bp if condition set explicitly Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zk6nkghi.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=marc.khouzam@ericsson.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox