From: Tom Tromey <tromey@redhat.com>
To: Marc Khouzam <marc.khouzam@ericsson.com>
Cc: "'gdb-patches\@sourceware.org'" <gdb-patches@sourceware.org>,
Pedro Alves <palves@redhat.com>
Subject: Re: [Patch] Cannot set pending bp if condition set explicitly
Date: Wed, 25 Jul 2012 20:44:00 -0000 [thread overview]
Message-ID: <87y5m7fu63.fsf@fleche.redhat.com> (raw)
In-Reply-To: <F7CE05678329534C957159168FA70DEC5C2500353F@EUSAACMS0703.eamcs.ericsson.se> (Marc Khouzam's message of "Wed, 25 Jul 2012 16:30:47 -0400")
Marc> I took the original line from print_one_exception_catchpoint()
Marc> when it figures out to print <PENDING>.
Yeah, I'm just not sure that this test is definitive in all cases.
Marc> But I changed it to use all_locations_are_pending() in the below
Marc> patch, and it also solves the problem I was seeing.
I'd like Pedro's input on this patch. I CC'd him.
Marc> How does it look for HEAD and 7_5 (not the tests
Marc> for 7_5 I gather)?
I think it is fine to put a new test onto the release branch.
The worst that can happen is a new FAIL -- but it isn't like the test
case is 0-FAIL in normal circumstances anyway.
Tom
next prev parent reply other threads:[~2012-07-25 20:44 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-24 14:45 Marc Khouzam
2012-07-25 15:28 ` Tom Tromey
2012-07-25 20:31 ` Marc Khouzam
2012-07-25 20:44 ` Tom Tromey [this message]
2012-07-26 19:05 ` Pedro Alves
2012-07-27 2:45 ` Marc Khouzam
2012-07-30 15:19 ` Pedro Alves
2012-07-30 15:36 ` Tom Tromey
2012-08-03 0:44 ` disable breakpoints with invalid condition (Re: [Patch] Cannot set pending bp if condition set explicitly) Pedro Alves
2012-08-03 0:51 ` [Patch] Cannot set pending bp if condition set explicitly Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y5m7fu63.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=marc.khouzam@ericsson.com \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox