From: Tom Tromey <tromey@redhat.com>
To: Phil Muldoon <pmuldoon@redhat.com>
Cc: "gdb-patches\@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [patch][python] 1 of 5 - Frame filter Python C code changes.
Date: Fri, 22 Mar 2013 17:15:00 -0000 [thread overview]
Message-ID: <87zjxvy2xw.fsf@fleche.redhat.com> (raw)
In-Reply-To: <87vc8kzd5d.fsf@fleche.redhat.com> (Tom Tromey's message of "Thu, 21 Mar 2013 14:55:10 -0600")
Phil> + else:
Phil> + # The end argument for islice is a count, not a position, so
Phil> + # add one as frames start at zero.
Phil> + frame_high = frame_high + 1;
Tom> I think it isn't a "count", since otherwise you'd have to subtract
Tom> frame_low.
Ok, I looked at the CLI patch and it seems to be passing in "count"
here. So maybe this note can be addressed by renaming the parameter.
Tom
next prev parent reply other threads:[~2013-03-22 13:34 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-11 22:13 Phil Muldoon
2013-03-21 20:55 ` Tom Tromey
2013-03-22 17:15 ` Tom Tromey [this message]
2013-03-26 17:17 ` Phil Muldoon
2013-03-27 18:36 ` Tom Tromey
-- strict thread matches above, loose matches on Subject: below --
2013-05-06 8:23 Phil Muldoon
2013-05-06 20:39 ` Tom Tromey
2013-05-09 13:23 ` Phil Muldoon
2013-05-09 15:14 ` Tom Tromey
2013-05-10 10:42 ` Phil Muldoon
2013-04-22 16:01 Phil Muldoon
2013-04-26 6:47 ` Tom Tromey
2012-11-30 14:31 Phil Muldoon
2012-12-05 17:03 ` Tom Tromey
2012-12-07 13:41 ` Phil Muldoon
2012-12-07 19:03 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zjxvy2xw.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=pmuldoon@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox