From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6991 invoked by alias); 22 Mar 2013 13:34:04 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 6842 invoked by uid 89); 22 Mar 2013 13:33:20 -0000 X-Spam-SWARE-Status: No, score=-8.1 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.1 Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Fri, 22 Mar 2013 13:33:17 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r2MDXGMM001327 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 22 Mar 2013 09:33:16 -0400 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id r2MDXFvf015970 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Fri, 22 Mar 2013 09:33:15 -0400 From: Tom Tromey To: Phil Muldoon Cc: "gdb-patches\@sourceware.org" Subject: Re: [patch][python] 1 of 5 - Frame filter Python C code changes. References: <513E56EC.2050802@redhat.com> <87vc8kzd5d.fsf@fleche.redhat.com> Date: Fri, 22 Mar 2013 17:15:00 -0000 In-Reply-To: <87vc8kzd5d.fsf@fleche.redhat.com> (Tom Tromey's message of "Thu, 21 Mar 2013 14:55:10 -0600") Message-ID: <87zjxvy2xw.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2013-03/txt/msg00850.txt.bz2 Phil> + else: Phil> + # The end argument for islice is a count, not a position, so Phil> + # add one as frames start at zero. Phil> + frame_high = frame_high + 1; Tom> I think it isn't a "count", since otherwise you'd have to subtract Tom> frame_low. Ok, I looked at the CLI patch and it seems to be passing in "count" here. So maybe this note can be addressed by renaming the parameter. Tom