Re: [PATCH v4 01/13] vla: introduce new bound type abstraction adapt uses

[Tom Tromey <tromey@redhat.com>]

Joel> I think that the _1 suffix is usually used when the function performs
Joel> the private portion of a more public routine.  But in this case,
Joel> create_range_type_1 is meant to be a public routine, and the _1
Joel> suffix is not very explicit.  IMO, what would be ideal would be to
Joel> rename the current create_range_type into "create_static_range_type",
Joel> and then make create_range_type_1 the new create_range_type. I checked
Joel> the GDB tree, and there aren't that many calls to update. If people
Joel> prefer, I can even take care of that myself once the patche series
Joel> has gone in. Otherwise, another compromise solution is to rename
Joel> create_range_type_1 to create_range_type_full (for instance).

Sanimir> Sounds good to me. I will prepend a patch doing the
Sanimir> create_range_type -> create_static_range_type thingy and use
Sanimir> create_range_type in this patch instead of create_range_type_1.

I guess this is one of the remaining blockers for this series now.
Though since Joel was agreeable I think it would be fine if you'd prefer
to do it as a follow-up.

Tom