From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3681 invoked by alias); 15 Jan 2014 21:39:23 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 3620 invoked by uid 89); 15 Jan 2014 21:39:22 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.1 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 15 Jan 2014 21:39:22 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s0FLdEFA006099 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 15 Jan 2014 16:39:15 -0500 Received: from barimba (ovpn-113-85.phx2.redhat.com [10.3.113.85]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s0FLdCxF014907 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Wed, 15 Jan 2014 16:39:13 -0500 From: Tom Tromey To: "Agovic\, Sanimir" Cc: "'Joel Brobecker'" , "palves\@redhat.com" , "xdje42\@gmail.com" , "gdb-patches\@sourceware.org" , "Boell\, Keven" Subject: Re: [PATCH v4 01/13] vla: introduce new bound type abstraction adapt uses References: <1387282678-3847-1-git-send-email-sanimir.agovic@intel.com> <1387282678-3847-2-git-send-email-sanimir.agovic@intel.com> <20131218032427.GD3493@adacore.com> <0377C58828D86C4588AEEC42FC3B85A7176CB92F@IRSMSX105.ger.corp.intel.com> Date: Wed, 15 Jan 2014 21:39:00 -0000 In-Reply-To: <0377C58828D86C4588AEEC42FC3B85A7176CB92F@IRSMSX105.ger.corp.intel.com> (Sanimir Agovic's message of "Wed, 18 Dec 2013 15:57:44 +0000") Message-ID: <87zjmworgf.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2014-01/txt/msg00572.txt.bz2 Joel> I think that the _1 suffix is usually used when the function performs Joel> the private portion of a more public routine. But in this case, Joel> create_range_type_1 is meant to be a public routine, and the _1 Joel> suffix is not very explicit. IMO, what would be ideal would be to Joel> rename the current create_range_type into "create_static_range_type", Joel> and then make create_range_type_1 the new create_range_type. I checked Joel> the GDB tree, and there aren't that many calls to update. If people Joel> prefer, I can even take care of that myself once the patche series Joel> has gone in. Otherwise, another compromise solution is to rename Joel> create_range_type_1 to create_range_type_full (for instance). Sanimir> Sounds good to me. I will prepend a patch doing the Sanimir> create_range_type -> create_static_range_type thingy and use Sanimir> create_range_type in this patch instead of create_range_type_1. I guess this is one of the remaining blockers for this series now. Though since Joel was agreeable I think it would be fine if you'd prefer to do it as a follow-up. Tom