From: Sergio Durigan Junior <sergiodj@sergiodj.net>
To: Simon Marchi <simon.marchi@polymtl.ca>
Cc: Simon Marchi <simon.marchi@ericsson.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH 1/4] environ-selftests: Ignore -Wself-move warning
Date: Wed, 21 Jun 2017 21:30:00 -0000 [thread overview]
Message-ID: <87zid1av1n.fsf@sergiodj.net> (raw)
In-Reply-To: <21fe0364a0d0b9e065dc1c812955950b@polymtl.ca> (Simon Marchi's message of "Wed, 21 Jun 2017 23:16:06 +0200")
On Wednesday, June 21 2017, Simon Marchi wrote:
> On 2017-06-21 22:29, Sergio Durigan Junior wrote:
>>> +#ifdef __clang__
>>> +#pragma clang diagnostic push
>>> +#pragma clang diagnostic ignored "-Wself-move"
>>> +#endif /* __clang__ */
>>> env = std::move (env);
>>> +#ifdef __clang__
>>> +#pragma clang diagnostic pop
>>> +#endif /* __clang__ */
>
>> Do you
>> think it's worth putting a comment on top, just to explicitly say what
>> this is doing?
>
> Forgot to reply to this. It seemed self-explanatory enough to me that
> ignoring the "self-move" warning just above a blatant self move was
> probably to silence a warning pointing out the self move :).
Yeah, you're right. I just thought a comment in English would make it
*even* clearer ;-). But that's just a personal preference, I don't
mind.
Cheers,
--
Sergio
GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36
Please send encrypted e-mail if possible
http://sergiodj.net/
next prev parent reply other threads:[~2017-06-21 21:30 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-21 20:15 [PATCH 0/4] Get rid of some more warnings given by clang Simon Marchi
2017-06-21 20:15 ` [PATCH 3/4] dtrace-probe: Put semicolon after while on its own line Simon Marchi
2017-06-21 20:34 ` Sergio Durigan Junior
2017-06-21 21:08 ` Simon Marchi
2017-06-21 21:36 ` Pedro Alves
2017-06-25 10:48 ` Simon Marchi
2017-06-25 10:57 ` Simon Marchi
2017-06-21 20:15 ` [PATCH 2/4] x86-dregs: Print debug registers one per line Simon Marchi
2017-06-21 20:31 ` Sergio Durigan Junior
2017-06-21 21:06 ` Simon Marchi
2017-06-25 10:58 ` Simon Marchi
2017-06-21 20:15 ` [PATCH 1/4] environ-selftests: Ignore -Wself-move warning Simon Marchi
2017-06-21 20:29 ` Sergio Durigan Junior
2017-06-21 21:05 ` Simon Marchi
2017-06-21 21:12 ` Sergio Durigan Junior
2017-06-21 21:28 ` Pedro Alves
2017-06-21 21:32 ` Sergio Durigan Junior
2017-06-22 7:44 ` Simon Marchi
2017-06-22 9:34 ` Pedro Alves
2017-06-21 21:16 ` Simon Marchi
2017-06-21 21:30 ` Sergio Durigan Junior [this message]
2017-06-22 8:31 ` [PATCH v2] " Simon Marchi
2017-06-22 9:51 ` Pedro Alves
2017-06-22 10:52 ` Pedro Alves
2017-06-22 10:57 ` Simon Marchi
2017-06-22 11:43 ` Pedro Alves
2017-06-21 20:15 ` [PATCH 4/4] main: Don't add int to string Simon Marchi
2017-06-21 20:35 ` Sergio Durigan Junior
2017-06-25 10:58 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zid1av1n.fsf@sergiodj.net \
--to=sergiodj@sergiodj.net \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@ericsson.com \
--cc=simon.marchi@polymtl.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox