From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 93887 invoked by alias); 21 Jun 2017 21:30:21 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 93470 invoked by uid 89); 21 Jun 2017 21:30:02 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.1 required=5.0 tests=AWL,BAYES_00,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy=personal X-HELO: kwanyin.sergiodj.net Received: from kwanyin.sergiodj.net (HELO kwanyin.sergiodj.net) (158.69.185.54) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 21 Jun 2017 21:30:00 +0000 From: Sergio Durigan Junior To: Simon Marchi Cc: Simon Marchi , gdb-patches@sourceware.org Subject: Re: [PATCH 1/4] environ-selftests: Ignore -Wself-move warning References: <1498076108-29914-1-git-send-email-simon.marchi@ericsson.com> <1498076108-29914-2-git-send-email-simon.marchi@ericsson.com> <87mv91ccey.fsf@sergiodj.net> <21fe0364a0d0b9e065dc1c812955950b@polymtl.ca> Date: Wed, 21 Jun 2017 21:30:00 -0000 In-Reply-To: <21fe0364a0d0b9e065dc1c812955950b@polymtl.ca> (Simon Marchi's message of "Wed, 21 Jun 2017 23:16:06 +0200") Message-ID: <87zid1av1n.fsf@sergiodj.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2017-06/txt/msg00617.txt.bz2 On Wednesday, June 21 2017, Simon Marchi wrote: > On 2017-06-21 22:29, Sergio Durigan Junior wrote: >>> +#ifdef __clang__ >>> +#pragma clang diagnostic push >>> +#pragma clang diagnostic ignored "-Wself-move" >>> +#endif /* __clang__ */ >>> env = std::move (env); >>> +#ifdef __clang__ >>> +#pragma clang diagnostic pop >>> +#endif /* __clang__ */ > >> Do you >> think it's worth putting a comment on top, just to explicitly say what >> this is doing? > > Forgot to reply to this. It seemed self-explanatory enough to me that > ignoring the "self-move" warning just above a blatant self move was > probably to silence a warning pointing out the self move :). Yeah, you're right. I just thought a comment in English would make it *even* clearer ;-). But that's just a personal preference, I don't mind. Cheers, -- Sergio GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36 Please send encrypted e-mail if possible http://sergiodj.net/