From: Tom Tromey <tom@tromey.com>
To: Simon Marchi <simon.marchi@ericsson.com>
Cc: Tom Tromey <tom@tromey.com>, <gdb-patches@sourceware.org>
Subject: Re: [PATCH] Remove some uses VEC from parsers
Date: Tue, 28 Aug 2018 17:35:00 -0000 [thread overview]
Message-ID: <87zhx65r92.fsf@tromey.com> (raw)
In-Reply-To: <2a9d9432-3bd3-f4c7-0817-dbf6ad7d655d@ericsson.com> (Simon Marchi's message of "Mon, 27 Aug 2018 17:35:31 -0400")
>>>>> "Simon" == Simon Marchi <simon.marchi@ericsson.com> writes:
>> else
>> {
>> - VEC_safe_push (token_and_value, token_fifo, &next);
>> + token_fifo.push_back (next);
>> }
Simon> Can you remove the extra braces, while at it?
Simon> LGTM, thanks!
I pushed it with this change.
Tom
prev parent reply other threads:[~2018-08-28 17:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-27 21:19 Tom Tromey
2018-08-27 21:35 ` Simon Marchi
2018-08-28 17:35 ` Tom Tromey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zhx65r92.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@ericsson.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox