From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 34410 invoked by alias); 28 Aug 2018 17:35:10 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 34396 invoked by uid 89); 28 Aug 2018 17:35:09 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-3.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: gateway24.websitewelcome.com Received: from gateway24.websitewelcome.com (HELO gateway24.websitewelcome.com) (192.185.50.66) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 28 Aug 2018 17:35:08 +0000 Received: from cm11.websitewelcome.com (cm11.websitewelcome.com [100.42.49.5]) by gateway24.websitewelcome.com (Postfix) with ESMTP id AE67CA3D6 for ; Tue, 28 Aug 2018 12:35:06 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id uhtSf7vWxRPojuhtSfY6Kh; Tue, 28 Aug 2018 12:35:06 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=SvDL6mzU/bMrawfgBIARV0J4XxTdHjoHSsFsTKxu3Ok=; b=BdsDj77F154ARG2oFZIaCeeJQl B+hzRzocCqaS7KGPwgswkfOGitDOOShPJ4y1Lbnus3d4Vf6ehSbJKpdZyGIHSBP6A8isAVQe6ohfp pWLqv5Tf0xapko3mAGPcYD9Bc; Received: from 75-166-85-72.hlrn.qwest.net ([75.166.85.72]:47908 helo=pokyo) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1fuhtS-001vI9-6f; Tue, 28 Aug 2018 12:35:06 -0500 From: Tom Tromey To: Simon Marchi Cc: Tom Tromey , Subject: Re: [PATCH] Remove some uses VEC from parsers References: <20180827211901.20992-1-tom@tromey.com> <2a9d9432-3bd3-f4c7-0817-dbf6ad7d655d@ericsson.com> Date: Tue, 28 Aug 2018 17:35:00 -0000 In-Reply-To: <2a9d9432-3bd3-f4c7-0817-dbf6ad7d655d@ericsson.com> (Simon Marchi's message of "Mon, 27 Aug 2018 17:35:31 -0400") Message-ID: <87zhx65r92.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2018-08/txt/msg00698.txt.bz2 >>>>> "Simon" == Simon Marchi writes: >> else >> { >> - VEC_safe_push (token_and_value, token_fifo, &next); >> + token_fifo.push_back (next); >> } Simon> Can you remove the extra braces, while at it? Simon> LGTM, thanks! I pushed it with this change. Tom