From: Tom Tromey <tom@tromey.com>
To: Sergio Durigan Junior <sergiodj@redhat.com>
Cc: Tom Tromey <tom@tromey.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] Remove variable in get_startup_shell non-static
Date: Sat, 15 Sep 2018 02:59:00 -0000 [thread overview]
Message-ID: <87zhwjqxcy.fsf@tromey.com> (raw)
In-Reply-To: <87k1npotux.fsf@redhat.com> (Sergio Durigan Junior's message of "Thu, 13 Sep 2018 19:33:42 -0400")
>>>>> "Sergio" == Sergio Durigan Junior <sergiodj@redhat.com> writes:
Sergio> IIRC this code was added by a patch of mine. I think your patch makes
Sergio> sense. Perhaps, since the SHELL can't change once you start GDB, this
Sergio> function could be made a bit smarter and check whether "ret" has been
Sergio> initialized or not (in order to call "getenv" just once), but really,
Sergio> that's not necessary at all, and your patch is totally fine.
I poked a little at the macOS shell / SIP thing. One possible solution
is copying the shell, and in this situation it's convenient if
get_startup_shell does not cache. I already checked this in, but I
thought I'd mention it anyway in case someone was tempted to change it.
Tom
prev parent reply other threads:[~2018-09-15 2:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-13 22:35 Tom Tromey
2018-09-13 23:33 ` Sergio Durigan Junior
2018-09-14 12:46 ` Tom Tromey
2018-09-15 2:59 ` Tom Tromey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zhwjqxcy.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=sergiodj@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox