From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 38667 invoked by alias); 15 Sep 2018 02:59:49 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 38634 invoked by uid 89); 15 Sep 2018 02:59:45 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-3.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: gateway30.websitewelcome.com Received: from gateway30.websitewelcome.com (HELO gateway30.websitewelcome.com) (192.185.197.25) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 15 Sep 2018 02:59:44 +0000 Received: from cm12.websitewelcome.com (cm12.websitewelcome.com [100.42.49.8]) by gateway30.websitewelcome.com (Postfix) with ESMTP id CF12779DE for ; Fri, 14 Sep 2018 21:59:42 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id 10oAgVjFhSjJA10oAg7Xnv; Fri, 14 Sep 2018 21:59:42 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=V+kf3WXEA6IXd1mbdFhIoEBitt7Zi1LuybBf63Enq7s=; b=XCbOJk3wprjuZDEUOpNYNhyqTO /HSjjuz+MtQfTt+snSjSjA0BOdFOfEK71eqEws9KrCyIaR4b+26YTle6X3hi2L5EYiBSL+QKG89Hn OQsnkotLrsrrkMwygQHw7qZgY; Received: from 97-122-190-66.hlrn.qwest.net ([97.122.190.66]:42262 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1g10oA-000u6h-J8; Fri, 14 Sep 2018 21:59:42 -0500 From: Tom Tromey To: Sergio Durigan Junior Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH] Remove variable in get_startup_shell non-static References: <20180913223416.12824-1-tom@tromey.com> <87k1npotux.fsf@redhat.com> Date: Sat, 15 Sep 2018 02:59:00 -0000 In-Reply-To: <87k1npotux.fsf@redhat.com> (Sergio Durigan Junior's message of "Thu, 13 Sep 2018 19:33:42 -0400") Message-ID: <87zhwjqxcy.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2018-09/txt/msg00477.txt.bz2 >>>>> "Sergio" == Sergio Durigan Junior writes: Sergio> IIRC this code was added by a patch of mine. I think your patch makes Sergio> sense. Perhaps, since the SHELL can't change once you start GDB, this Sergio> function could be made a bit smarter and check whether "ret" has been Sergio> initialized or not (in order to call "getenv" just once), but really, Sergio> that's not necessary at all, and your patch is totally fine. I poked a little at the macOS shell / SIP thing. One possible solution is copying the shell, and in this situation it's convenient if get_startup_shell does not cache. I already checked this in, but I thought I'd mention it anyway in case someone was tempted to change it. Tom