From: Tom Tromey <tom@tromey.com>
To: Joel Brobecker <brobecker@adacore.com>
Cc: Tom Tromey <tom@tromey.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH 00/12] Remove some ALL_* iteration macros
Date: Mon, 24 Dec 2018 20:54:00 -0000 [thread overview]
Message-ID: <87zhsuprvq.fsf@tromey.com> (raw)
In-Reply-To: <20181223070033.GB8096@adacore.com> (Joel Brobecker's message of "Sun, 23 Dec 2018 11:00:33 +0400")
>>>>> "Joel" == Joel Brobecker <brobecker@adacore.com> writes:
Joel> As for the downside, I don't consider re-indentation a downside
Joel> other than it makes review a bit more painful. The two-nested
Joel> loop didn't seem like they were making the code less readable.
Joel> Did you have any other concerns with that?
Nope.
Joel> I admit I was scanning the last few patches much faster than the first
Joel> few ones, but they seem fairly mechanical to me, so I think the risk
Joel> is low.
I think I will have to redo much of the series to account for that
version of gcc that Simon sometimes uses -- the one that requires ranged
for loops to use the "struct" keyword. I probably can't really test
that change but I'll make a best effort at it in order to reduce the
amount of work he has to do.
Tom
next prev parent reply other threads:[~2018-12-24 20:54 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-25 16:54 Tom Tromey
2018-11-25 16:54 ` [PATCH 04/12] Remove ALL_OBJFILES_SAFE Tom Tromey
2018-11-25 16:54 ` [PATCH 08/12] Remove ALL_COMPUNIT_FILETABS Tom Tromey
2018-11-25 16:54 ` [PATCH 11/12] Remove ALL_OBJSECTIONS Tom Tromey
2018-11-25 16:54 ` [PATCH 05/12] Remove ALL_MSYMBOLS and ALL_OBJFILE_MSYMBOLS Tom Tromey
2018-11-25 16:54 ` [PATCH 07/12] Remove ALL_COMPUNITS Tom Tromey
2018-11-25 16:54 ` [PATCH 09/12] Remove ALL_OBJFILE_FILETABS Tom Tromey
2018-11-25 16:54 ` [PATCH 10/12] Remove ALL_OBJFILES and ALL_FILETABS Tom Tromey
2018-11-25 16:54 ` [PATCH 03/12] Remove most uses of ALL_OBJFILES Tom Tromey
2018-11-25 16:54 ` [PATCH 12/12] Remove ALL_OBJFILE_PSYMTABS Tom Tromey
2018-11-25 16:54 ` [PATCH 01/12] Introduce all_objfiles and next_iterator Tom Tromey
2018-11-25 16:55 ` [PATCH 06/12] Remove ALL_OBJFILE_COMPUNITS Tom Tromey
2018-11-25 16:55 ` [PATCH 02/12] Remove ALL_PSPACE_OBJFILES Tom Tromey
2018-12-23 7:00 ` [PATCH 00/12] Remove some ALL_* iteration macros Joel Brobecker
2018-12-24 20:54 ` Tom Tromey [this message]
2018-12-26 17:30 ` Simon Marchi
2018-12-26 22:28 ` Tom Tromey
2018-12-26 22:32 ` Tom Tromey
2018-12-26 22:35 ` Simon Marchi
2018-12-26 22:52 ` Tom Tromey
2018-12-26 23:45 ` Tom Tromey
2018-12-27 0:46 ` Simon Marchi
2018-12-27 6:22 ` Tom Tromey
2018-12-27 1:52 ` Simon Marchi
2019-01-03 21:46 ` Tom Tromey
2019-01-03 22:45 ` Simon Marchi
2019-01-06 20:10 ` Tom Tromey
2019-01-09 19:49 ` Simon Marchi
2019-01-10 1:29 ` Tom Tromey
2019-01-10 16:45 ` Pedro Alves
2019-01-10 18:10 ` Tom Tromey
2019-01-10 19:58 ` Pedro Alves
2019-01-10 16:44 ` Pedro Alves
2019-01-10 18:06 ` Tom Tromey
2019-01-10 18:09 ` Pedro Alves
2019-01-10 22:53 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zhsuprvq.fsf@tromey.com \
--to=tom@tromey.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox