From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 54025 invoked by alias); 24 Dec 2018 20:54:53 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 54010 invoked by uid 89); 24 Dec 2018 20:54:53 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=mechanical, Hx-languages-length:860, admit, risk X-HELO: gateway30.websitewelcome.com Received: from gateway30.websitewelcome.com (HELO gateway30.websitewelcome.com) (192.185.150.24) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 24 Dec 2018 20:54:52 +0000 Received: from cm10.websitewelcome.com (cm10.websitewelcome.com [100.42.49.4]) by gateway30.websitewelcome.com (Postfix) with ESMTP id 02F1B150C0 for ; Mon, 24 Dec 2018 14:54:51 -0600 (CST) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id bXFSgTpwD2PzObXFTgCfNK; Mon, 24 Dec 2018 14:54:51 -0600 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=FRGeM0mp36T0+/B4Cj+MxoT5Xv736+ktMFynpYHbD7w=; b=jUPJXcstwKj1l7jJ71nHdGMnbD NBX4MSEbTbFX6+qXucxKdSjc3kfDZWZWSvE6UjbU07JQ+r6Ul0gb0VQMtRSKi7bwHw7k7ZM526j82 IFVgjHgRL2697DLwHhzRo5RJZ; Received: from 75-166-72-210.hlrn.qwest.net ([75.166.72.210]:50254 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1gbXFS-002nEi-Ph; Mon, 24 Dec 2018 14:54:50 -0600 From: Tom Tromey To: Joel Brobecker Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH 00/12] Remove some ALL_* iteration macros References: <20181125165439.13773-1-tom@tromey.com> <20181223070033.GB8096@adacore.com> Date: Mon, 24 Dec 2018 20:54:00 -0000 In-Reply-To: <20181223070033.GB8096@adacore.com> (Joel Brobecker's message of "Sun, 23 Dec 2018 11:00:33 +0400") Message-ID: <87zhsuprvq.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2018-12/txt/msg00307.txt.bz2 >>>>> "Joel" == Joel Brobecker writes: Joel> As for the downside, I don't consider re-indentation a downside Joel> other than it makes review a bit more painful. The two-nested Joel> loop didn't seem like they were making the code less readable. Joel> Did you have any other concerns with that? Nope. Joel> I admit I was scanning the last few patches much faster than the first Joel> few ones, but they seem fairly mechanical to me, so I think the risk Joel> is low. I think I will have to redo much of the series to account for that version of gcc that Simon sometimes uses -- the one that requires ranged for loops to use the "struct" keyword. I probably can't really test that change but I'll make a best effort at it in order to reduce the amount of work he has to do. Tom