From: Tom Tromey <tom@tromey.com>
To: Tom de Vries <tdevries@suse.de>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH][gdb] Skip imports of c++ CUs
Date: Thu, 12 Mar 2020 12:44:35 -0600 [thread overview]
Message-ID: <87zhclifak.fsf@tromey.com> (raw)
In-Reply-To: <20200302161322.GA13204@delia> (Tom de Vries's message of "Mon, 2 Mar 2020 17:13:24 +0100")
>>>>> "Tom" == Tom de Vries <tdevries@suse.de> writes:
Tom> 2020-03-02 Tom de Vries <tdevries@suse.de>
Tom> PR gdb/23710
Tom> * dwarf2/read.h (struct dwarf2_per_cu_data): Add unit_type and lang
Tom> fields.
Tom> * dwarf2/read.c (process_psymtab_comp_unit): Initialize unit_type and lang
Tom> fields.
Tom> (process_imported_unit_die): Skip import of c++ CUs.
I guess this works out ok because dwarf2_per_cu_data and its
"subclasses" are memset to 0 just after allocation, and so we'll never
see a match by accident.
A nice cleanup for the "someday" list would be to allocate these objects
with "new" so we can have real initializers.
The patch looks good to me. Thank you for doing this.
Tom
prev parent reply other threads:[~2020-03-12 18:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-02 16:13 Tom de Vries
2020-03-12 18:44 ` Tom Tromey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zhclifak.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=tdevries@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox