From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gateway36.websitewelcome.com (gateway36.websitewelcome.com [192.185.186.5]) by sourceware.org (Postfix) with ESMTPS id 623F83877015 for ; Thu, 12 Mar 2020 18:44:38 +0000 (GMT) Received: from cm11.websitewelcome.com (cm11.websitewelcome.com [100.42.49.5]) by gateway36.websitewelcome.com (Postfix) with ESMTP id D282E400C7A4A for ; Thu, 12 Mar 2020 13:00:16 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id CSoujJEg2Sl8qCSoujthrh; Thu, 12 Mar 2020 13:44:36 -0500 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=mhHTc13spd69zrkZXLd5pKaw6X9LXoNxMwhHn0d0TvQ=; b=g7L1/wk1cifPj20UT0p5JEM4z0 LSVrLSAjRlVmhL5smKyBrmh9CJJq7x7ZHUGH+A4x+ycSMqWoexEop/0n8zxtI2s5MQHqhgz5dAXa7 L9y8T9knNgiCTDNenCMhSVNqB; Received: from 184-96-250-69.hlrn.qwest.net ([184.96.250.69]:60682 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1jCSou-001vvh-DE; Thu, 12 Mar 2020 12:44:36 -0600 From: Tom Tromey To: Tom de Vries Cc: gdb-patches@sourceware.org Subject: Re: [PATCH][gdb] Skip imports of c++ CUs References: <20200302161322.GA13204@delia> X-Attribution: Tom Date: Thu, 12 Mar 2020 12:44:35 -0600 In-Reply-To: <20200302161322.GA13204@delia> (Tom de Vries's message of "Mon, 2 Mar 2020 17:13:24 +0100") Message-ID: <87zhclifak.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 184.96.250.69 X-Source-L: No X-Exim-ID: 1jCSou-001vvh-DE X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 184-96-250-69.hlrn.qwest.net (murgatroyd) [184.96.250.69]:60682 X-Source-Auth: tom+tromey.com X-Email-Count: 11 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, RCVD_IN_DNSWL_NONE, SPF_HELO_PASS, SPF_NEUTRAL autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 12 Mar 2020 18:44:39 -0000 >>>>> "Tom" == Tom de Vries writes: Tom> 2020-03-02 Tom de Vries Tom> PR gdb/23710 Tom> * dwarf2/read.h (struct dwarf2_per_cu_data): Add unit_type and lang Tom> fields. Tom> * dwarf2/read.c (process_psymtab_comp_unit): Initialize unit_type and lang Tom> fields. Tom> (process_imported_unit_die): Skip import of c++ CUs. I guess this works out ok because dwarf2_per_cu_data and its "subclasses" are memset to 0 just after allocation, and so we'll never see a match by accident. A nice cleanup for the "someday" list would be to allocate these objects with "new" so we can have real initializers. The patch looks good to me. Thank you for doing this. Tom