From: Andreas Schwab <schwab@linux-m68k.org>
To: Tom de Vries via Gdb-patches <gdb-patches@sourceware.org>
Cc: Pedro Alves <pedro@palves.net>
Subject: Re: [PATCH][gdb/c] Fix printing -2147483648
Date: Wed, 18 May 2022 21:00:17 +0200 [thread overview]
Message-ID: <87zgjemzsu.fsf@igel.home> (raw)
In-Reply-To: <20220518173840.GA8909@delia> (Tom de Vries via Gdb-patches's message of "Wed, 18 May 2022 19:38:42 +0200")
On Mai 18 2022, Tom de Vries via Gdb-patches wrote:
> +static bool
> +fits_in_type (int n_sign, ULONGEST n, int type_bits, bool type_signed_p)
n_sign is always 1, you can just remove it.
> + if (have_int && have_signed && fits_in_type (1, n, int_bits, 1))
type_signed_p is a bool, so you should use true and false.
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1
"And now for something completely different."
next prev parent reply other threads:[~2022-05-18 19:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-18 17:38 Tom de Vries via Gdb-patches
2022-05-18 19:00 ` Andreas Schwab [this message]
2022-05-23 11:14 ` Tom de Vries via Gdb-patches
2022-05-18 19:15 ` Pedro Alves
2022-05-23 11:16 ` Tom de Vries via Gdb-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zgjemzsu.fsf@igel.home \
--to=schwab@linux-m68k.org \
--cc=gdb-patches@sourceware.org \
--cc=pedro@palves.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox