From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id bqoDAl5ChWIP9QYAWB0awg (envelope-from ) for ; Wed, 18 May 2022 15:00:46 -0400 Received: by simark.ca (Postfix, from userid 112) id EF9691E220; Wed, 18 May 2022 15:00:45 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.9 required=5.0 tests=BAYES_00,MAILING_LIST_MULTI autolearn=ham autolearn_force=no version=3.4.6 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 651681E00D for ; Wed, 18 May 2022 15:00:45 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id A67DE38485B9 for ; Wed, 18 May 2022 19:00:44 +0000 (GMT) Received: from mail-out.m-online.net (mail-out.m-online.net [212.18.0.9]) by sourceware.org (Postfix) with ESMTPS id CAF16384B07C for ; Wed, 18 May 2022 19:00:19 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org CAF16384B07C Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=linux-m68k.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=nefkom.net Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 4L3MkV59Nlz1r153; Wed, 18 May 2022 21:00:18 +0200 (CEST) Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 4L3MkV27nTz1qqkD; Wed, 18 May 2022 21:00:18 +0200 (CEST) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id leOdeGuVg_tj; Wed, 18 May 2022 21:00:17 +0200 (CEST) X-Auth-Info: bS+Oh7/pnwEXeNdpIEZlNTYcouYaEG9f7wU+yqeVlU5Nzk8NiP20/Km/2cusBsyv Received: from igel.home (ppp-46-244-188-110.dynamic.mnet-online.de [46.244.188.110]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPSA; Wed, 18 May 2022 21:00:17 +0200 (CEST) Received: by igel.home (Postfix, from userid 1000) id 216122C3A74; Wed, 18 May 2022 21:00:17 +0200 (CEST) From: Andreas Schwab To: Tom de Vries via Gdb-patches Subject: Re: [PATCH][gdb/c] Fix printing -2147483648 References: <20220518173840.GA8909@delia> X-Yow: I can't think about that. It doesn't go with HEDGES in the shape of LITTLE LULU -- or ROBOTS making BRICKS... Date: Wed, 18 May 2022 21:00:17 +0200 In-Reply-To: <20220518173840.GA8909@delia> (Tom de Vries via Gdb-patches's message of "Wed, 18 May 2022 19:38:42 +0200") Message-ID: <87zgjemzsu.fsf@igel.home> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Pedro Alves Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" On Mai 18 2022, Tom de Vries via Gdb-patches wrote: > +static bool > +fits_in_type (int n_sign, ULONGEST n, int type_bits, bool type_signed_p) n_sign is always 1, you can just remove it. > + if (have_int && have_signed && fits_in_type (1, n, int_bits, 1)) type_signed_p is a bool, so you should use true and false. -- Andreas Schwab, schwab@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for something completely different."