Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tromey@adacore.com>
To: Tom de Vries <tdevries@suse.de>
Cc: Tom Tromey <tromey@adacore.com>,  gdb-patches@sourceware.org
Subject: Re: [PATCH] Fix crash in DWARF indexer
Date: Tue, 07 Jan 2025 07:40:04 -0700	[thread overview]
Message-ID: <87zfk24ri3.fsf@tromey.com> (raw)
In-Reply-To: <5b9ee29a-a5f8-46e7-bbe6-976633c1b209@suse.de> (Tom de Vries's message of "Tue, 7 Jan 2025 13:10:24 +0100")

>>>>> "Tom" == Tom de Vries <tdevries@suse.de> writes:

Tom> I think that indenting the code makes it harder to read.
...

>> +standard_testfile main.c nameless-enum.S

Tom> Using nameless-enum.S is not necessary, we can just use:
Tom> ...
Tom> standard_testfile main.c .S
Tom> ...

I made these changes.

Tom

  reply	other threads:[~2025-01-07 14:40 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-06 20:40 Tom Tromey
2025-01-07 12:10 ` Tom de Vries
2025-01-07 14:40   ` Tom Tromey [this message]
2025-01-07 14:45 ` Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87zfk24ri3.fsf@tromey.com \
    --to=tromey@adacore.com \
    --cc=gdb-patches@sourceware.org \
    --cc=tdevries@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox