From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id xCWaHvM8fWdAJwYAWB0awg (envelope-from ) for ; Tue, 07 Jan 2025 09:40:51 -0500 Authentication-Results: simark.ca; dkim=pass (2048-bit key; secure) header.d=adacore.com header.i=@adacore.com header.a=rsa-sha256 header.s=google header.b=Yz+NOY8O; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 705A41E0C0; Tue, 7 Jan 2025 09:40:51 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.0 (2022-12-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.0 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 7CA841E05C for ; Tue, 7 Jan 2025 09:40:47 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 14EA0385772C for ; Tue, 7 Jan 2025 14:40:47 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 14EA0385772C Authentication-Results: sourceware.org; dkim=pass (2048-bit key, secure) header.d=adacore.com header.i=@adacore.com header.a=rsa-sha256 header.s=google header.b=Yz+NOY8O Received: from mail-io1-xd29.google.com (mail-io1-xd29.google.com [IPv6:2607:f8b0:4864:20::d29]) by sourceware.org (Postfix) with ESMTPS id B27143857722 for ; Tue, 7 Jan 2025 14:40:06 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B27143857722 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org B27143857722 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::d29 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1736260806; cv=none; b=alAovsWTB2MDflkrVk3XKSh7NuLjFDUb+6J/eN54gqkXcZdhchi0SulzJmu5caRgsFoc3EviZ0J8TfW0ocqx4PKruZFIRW70lnYiCgEG5abfkA8aYY+uKtWcqF1XN7AUwfBmV8M0MwFRcqEQeKlxE5yFKo9R55cMk9/ee5NO0eU= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1736260806; c=relaxed/simple; bh=9JXM5BwxeOFHmyiatcjjvfxuMfMNgZy7aSnvGFLcza0=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=vkzJONUqKSUoK7xyTBO7cDQrXjtfu5Adxgr6RvaJjtJd8SAWFxb9FOPNAaQ5pQrh2xjv6xMLUMEriAeFGtXIXU1rp45lrlMCBQULZxPFBfd2MThZfg8yAM2ExDxJ4VsF+D5xJBzFgqzECjgzYwBcnh9dBNJRxl+KYbsBNGvh/T8= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org B27143857722 Received: by mail-io1-xd29.google.com with SMTP id ca18e2360f4ac-844cd85f5ebso1289034939f.3 for ; Tue, 07 Jan 2025 06:40:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1736260806; x=1736865606; darn=sourceware.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=9JXM5BwxeOFHmyiatcjjvfxuMfMNgZy7aSnvGFLcza0=; b=Yz+NOY8OQ3fzbR1C7xv9DmTjbndURN3nrfdNjcHM2HeZp5KSFJbkvCHxKNYb45Lu8Z SIxqQYAfzQ7fOiDTA2Q7A6E2+6kpDnmHXFyy/iKLbO77CUGuCzIi4w7Gzfq4aVV0Vfgu dAx2SyZzixkqa3x9zKcxaOmYiqw5rQaNsQRUsor1dEtRIFmZjHbm0tWKdgFc04qVWcVI fBzVNNvY6h6vSxiaS7P3BV6eDIHBgfy4y7rrbr1g4H3lv+LvKiyIhRvsmAapL/V54A+v /G97qBCj+Yn+J/lpFfqkT5Wj6s1p5pwKrTjLH1AHaFru4P3RPVTC9Enoo1FgbFydkprr c/Yg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736260806; x=1736865606; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=9JXM5BwxeOFHmyiatcjjvfxuMfMNgZy7aSnvGFLcza0=; b=CRnmOUMeyTzvzvqAWrVyyGsv8uHx5gQeGVMevvs8N1NRkjlCvJWDvMpaNtVmQHrLy+ KNanmWIhT+hgPzZy7CbwBJl2jA2KTm/Pegh+EF+67hyx9eH0z02LQCHdQtkZE6GG2oRx r8CQ9O8UjKZKZfF9l/w593lSFy/mmOt9k32ZysCm6MSif4ckOPx01LuvFosRtwiLRMV8 wGl3hOpvAKigt4vEQxpjLQaZ2ou1WgEbs3/Cerb0b74yVJ2PWkLu/WXwLEdr1HI3J8zr HXOMLbgK2pk4FvEbDg3PqVDxwDzw56shAlndJQlKvWFFrye8pOFH/Bj2UK39QBIHMiHf 3pVw== X-Forwarded-Encrypted: i=1; AJvYcCVqjsf9rantignZPHZ62QRYZe4WPB8iTOdN9E6kp3De78TwIEMwcCNJdlczqXp4L/ub/1QuR94dcFe+bA==@sourceware.org X-Gm-Message-State: AOJu0Ywd0cuey7RJ5QSneoe7+UU+CoX2v856tSLZtgxXA/udqGL6YiIJ vh3CziVGWXWX0jd7UJBrlNVfdML+4RKojvoqGRKm9UniGMW2pnCn4CM85kQQJw== X-Gm-Gg: ASbGncurCsKk+nO6a0R+ojqxEMyu/oHC0kxSSZGnnsJBuHpqRMGYH6ToUiXx4lBuV7A LzRLYd/dU4IakdQimgG5/JIlrYw5NsniQqmzQTBwLVDYcL8OYNosHz3q3Ud1+N0rNy4SSBj5R0y +DVsRvddLobJxl+ozdcmYnjGPyNu6WLBr1Q14lwlVgNl4V1kHKOTovcouPzu5MdF5BAalxxcrYa CDc69trj3ck9gEVrSUP8zy/Oxd1y94J/2Vid+wXo0pc9W0+f+aGfjiPtIrTDa7YailM2E6SawLB lQET9A== X-Google-Smtp-Source: AGHT+IGK1Jydnej24nKWqju9kI30IhRpVdBNN75PqhK2d1AR6U6E3Wkqu6FWfb2AE2Sm4XbmSama1g== X-Received: by 2002:a92:ca4a:0:b0:3a7:7d26:4ce4 with SMTP id e9e14a558f8ab-3c2d268133fmr567888755ab.9.1736260805902; Tue, 07 Jan 2025 06:40:05 -0800 (PST) Received: from murgatroyd (97-118-36-154.hlrn.qwest.net. [97.118.36.154]) by smtp.gmail.com with ESMTPSA id e9e14a558f8ab-3c0e3f36328sm101945125ab.56.2025.01.07.06.40.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Jan 2025 06:40:05 -0800 (PST) From: Tom Tromey To: Tom de Vries Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH] Fix crash in DWARF indexer In-Reply-To: <5b9ee29a-a5f8-46e7-bbe6-976633c1b209@suse.de> (Tom de Vries's message of "Tue, 7 Jan 2025 13:10:24 +0100") References: <20250106204028.3587605-1-tromey@adacore.com> <5b9ee29a-a5f8-46e7-bbe6-976633c1b209@suse.de> X-Attribution: Tom Date: Tue, 07 Jan 2025 07:40:04 -0700 Message-ID: <87zfk24ri3.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org >>>>> "Tom" == Tom de Vries writes: Tom> I think that indenting the code makes it harder to read. ... >> +standard_testfile main.c nameless-enum.S Tom> Using nameless-enum.S is not necessary, we can just use: Tom> ... Tom> standard_testfile main.c .S Tom> ... I made these changes. Tom