Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Sven Schnelle <svens@stackframe.org>
To: Simon Marchi <simark@simark.ca>
Cc: gdb-patches@sourceware.org,  Helge Deller <deller@gmx.de>,
	 John David Anglin <dave.anglin@bell.net>,
	 binutils@sourceware.org
Subject: Re: [PATCH v3] gdb/hppa: guess g packet size
Date: Mon, 10 Nov 2025 22:34:00 +0100	[thread overview]
Message-ID: <87zf8th8s7.fsf@stackframe.org> (raw)
In-Reply-To: <d9e159b9-53eb-4f89-9a3b-f7865ba35b03@simark.ca> (Simon Marchi's message of "Mon, 10 Nov 2025 16:29:33 -0500")

Simon Marchi <simark@simark.ca> writes:

>> +	  warning (_("target returned a target description this gdb doesn't "
>> +		     "support for the HP/PA architecture"));
>
> Good idea to put out a warning.  I would suggesting some minor changes
> to the message:
>
> 	  warning (_("The target returned a target description but this gdb "
> 		     "doesn't support target descriptions for the HP/PA
> 		     "architecture"));
>
> Just thinking out loud: it would actually be nice to have this warning
> for all architectures that don't support target descriptions, if there
> was a way to put it at a single common place.
>
> Other than that, the patch looks fine.
>
> Approved-By: Simon Marchi <simon.marchi@efficios.com>
>
> Do you have push access or would you like me to push the patch on your
> behalf (with the modification proposed above)?

I don't have push acess - would appreciate if you could adjust the
message and push it.

  reply	other threads:[~2025-11-10 21:38 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-10 21:07 Sven Schnelle
2025-11-10 21:29 ` Simon Marchi
2025-11-10 21:34   ` Sven Schnelle [this message]
2025-11-10 21:38     ` Simon Marchi
2025-11-10 21:39       ` Sven Schnelle
2025-11-10 22:51         ` Simon Marchi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87zf8th8s7.fsf@stackframe.org \
    --to=svens@stackframe.org \
    --cc=binutils@sourceware.org \
    --cc=dave.anglin@bell.net \
    --cc=deller@gmx.de \
    --cc=gdb-patches@sourceware.org \
    --cc=simark@simark.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox