From: Tom Tromey <tom@tromey.com>
To: Simon Marchi <simon.marchi@efficios.com>
Cc: gdb-patches@sourceware.org, Simon Marchi <simon.marchi@polymtl.ca>
Subject: Re: [PATCH] gdb/dwarf: fix order of operations when reading .debug_names
Date: Wed, 20 May 2026 09:15:23 -0600 [thread overview]
Message-ID: <87zf1u9kok.fsf@tromey.com> (raw)
In-Reply-To: <20260519200917.342813-1-simon.marchi@efficios.com> (Simon Marchi's message of "Tue, 19 May 2026 16:09:10 -0400")
>>>>> "Simon" == Simon Marchi <simon.marchi@efficios.com> writes:
Simon> - calls to the build_and_check_* functions, which do some lookups in
Simon> the all_units vector, requiring it to be sorted (oops)
I wonder if either there's some way to assert that the vector must be
sorted on entry, or if there's a way to have a self-sorting data type
here, rendering this kind of bug impossible.
Anyway I think this is ok.
Approved-By: Tom Tromey <tom@tromey.com>
Tom
next prev parent reply other threads:[~2026-05-20 15:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-19 20:09 Simon Marchi
2026-05-20 15:15 ` Tom Tromey [this message]
2026-05-20 15:38 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zf1u9kok.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@efficios.com \
--cc=simon.marchi@polymtl.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox