From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 2VTUAyzQDWrKagoAWB0awg (envelope-from ) for ; Wed, 20 May 2026 11:15:56 -0400 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=eoUnKzcI; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 0958A1E098; Wed, 20 May 2026 11:15:56 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_BL_SPAMCOP_NET, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=no autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 6FBB31E024 for ; Wed, 20 May 2026 11:15:55 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 3D83E4BB5910 for ; Wed, 20 May 2026 15:15:54 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 3D83E4BB5910 Authentication-Results: sourceware.org; dkim=fail reason="signature verification failed" (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=eoUnKzcI Received: from omta34.uswest2.a.cloudfilter.net (omta34.uswest2.a.cloudfilter.net [35.89.44.33]) by sourceware.org (Postfix) with ESMTPS id 900774BB24FB for ; Wed, 20 May 2026 15:15:28 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 900774BB24FB Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 900774BB24FB Authentication-Results: sourceware.org; arc=none smtp.remote-ip=35.89.44.33 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1779290128; cv=none; b=C9s62XESuxQwDnDdoCy0ge6PGpuRRFP+4kAN01/izKY0gvDTeLLVK6CISkt2IjBSBgw2GjCaCr+nWPb9PbpYyZNxPzCUQ826Zgx6HaH2i7HLhpM7QWqmtIvXxnk0GMrGCFBBNSkKXA8wcyXhgKjgQKFvIqt7Ye7JHWLK0tt3lEE= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1779290128; c=relaxed/simple; bh=C+J22qRiOFkNiqusnVNaS+5PECj0Gc1ADWFv5poTjFE=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=IXP30jzvMbaujh7wAJFeqFyR/nUizcthgQA79yoGSilnLD3gtEC9UR/8hcvB2iceZX6qmKbDyUMp9s9bKyQsaRmHsHa+g92hSOsR1LaWHqUWSWkMTVjHs9EtjQgZzgRauTiaLZT5RubBo03mQiekoNoQ4EChieRKPB3qNVTt3WM= ARC-Authentication-Results: i=1; sourceware.org; dkim=policy (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=eoUnKzcI reason="signing key too small" DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 900774BB24FB Received: from eig-obgw-6006b.ext.cloudfilter.net ([10.0.30.211]) by cmsmtp with ESMTPS id PiWwwH3zslPo5PidrwKlqX; Wed, 20 May 2026 15:15:27 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id Pidow9JSdWBahPidpwo0bz; Wed, 20 May 2026 15:15:25 +0000 X-Authority-Analysis: v=2.4 cv=Y9D4sgeN c=1 sm=1 tr=0 ts=6a0dd00f a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=NGcC8JguVDcA:10 a=ItBw4LHWJt0A:10 a=7d_E57ReAAAA:8 a=zstS-IiYAAAA:8 a=HAi0yCPSccWLjCJsr9MA:9 a=jhqOcbufqs7Y1TYCrUUU:22 a=4G6NA9xxw8l3yy4pmD5M:22 a=DCx65vhANUyCzuf5D8fC:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=obY+vhGGwqlsIRQ6OwjOtvTrOM4oYnN+Cy2qSzrZOpE=; b=eoUnKzcIG9vAkkD26Lrp8vBFfh V+vuCnEKMrILwG6lrOUblxFG/97AT9mrDE3wynFsPj2ietUxuCtJuNAFC4IeIgtO0+MbYwUDjkBYy QlVe3srjJejLKXrZtsoSP2VeP; Received: from 75-166-225-82.hlrn.qwest.net ([75.166.225.82]:35194 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.99.2) (envelope-from ) id 1wPido-00000004KZX-1yxT; Wed, 20 May 2026 09:15:24 -0600 From: Tom Tromey To: Simon Marchi Cc: gdb-patches@sourceware.org, Simon Marchi Subject: Re: [PATCH] gdb/dwarf: fix order of operations when reading .debug_names In-Reply-To: <20260519200917.342813-1-simon.marchi@efficios.com> (Simon Marchi's message of "Tue, 19 May 2026 16:09:10 -0400") References: <20260519200917.342813-1-simon.marchi@efficios.com> X-Attribution: Tom Date: Wed, 20 May 2026 09:15:23 -0600 Message-ID: <87zf1u9kok.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.225.82 X-Source-L: No X-Exim-ID: 1wPido-00000004KZX-1yxT X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-225-82.hlrn.qwest.net (bapiya) [75.166.225.82]:35194 X-Source-Auth: tom+tromey.com X-Email-Count: 6 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfOqx0vjwU/9XVUvuaANKIWnYrLYqdNCfzAGVuTduWfMomb8wokURVkWlT9yaVmwjJnJiZXyYybhIu2jxs+DtRVLCRG82xKVhMIj/m5bmZJe+BfOuQ8Ja DPmdYMd5OsIdWBakfhlwHpJlbisIAUwEGyXqmJKsHFODSMe/3CCixk7U8IBk0YHzUtXF/+HCKfbHCgJShbb7QrONy/OOL1ioDDo= X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org >>>>> "Simon" == Simon Marchi writes: Simon> - calls to the build_and_check_* functions, which do some lookups in Simon> the all_units vector, requiring it to be sorted (oops) I wonder if either there's some way to assert that the vector must be sorted on entry, or if there's a way to have a self-sorting data type here, rendering this kind of bug impossible. Anyway I think this is ok. Approved-By: Tom Tromey Tom