Re: [PATCH 1/1] gdb, testsuite: unify 'Switching to thread' message

[Tom Tromey <tom@tromey.com>]

>>>>> Stephan Rohr <stephan.rohr@intel.com> writes:

> From: "Rohr, Stephan" <stephan.rohr@intel.com>
> The 'normal_stop ()' function in infrun prints
>   [Switching to Thread 0x155554dff6c0 (LWP 77976)]
> on thread switch.  The 'print_selected_thread_frame ()' function
> in thread.c prints
>   [Switching to thread 2 (Thread 0x155554dff6c0 (LWP 96643))]
> Ensure consistent output by updating the thread switch message in
> 'normal_stop ()'.

I'm in favor of uniformity so I'm in favor of the core part of the
patch.  See below.

Also see commit f99be06d where some other things display thread info
differently:

        [New Thread 0x7ffff7cbe6c0 (LWP 1267702) (id 2)]
        [Thread 0x7ffff6cbd6c0 (LWP 1267703) (id 3) exited]

Maybe we ought to make those more uniform as well.
You don't have to do this in order to land this patch though.

> -		-re "^\\\[Switching to Thread\[^\r\n\]+\\\]\r\n" {
> +		-re "^\\\[Switching to thread\[^\r\n\]+\\\]\r\n" {
> +		    puts "XXX: Consume switching to thread line"
>  		    verbose -log "XXX: Consume switching to thread line"
> -		    exp_continue
> +		    fail $gdb_test_name

This seems wrong.  At least the puts is clearly just for debugging
(unclear why the verbose wasn't enough); but I think the 'fail' is a
leftover too.

Ok with this hunk fixed up.
Approved-By: Tom Tromey <tom@tromey.com>

Tom