From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id COf/GUP0MmpfTQwAWB0awg (envelope-from ) for ; Wed, 17 Jun 2026 15:23:47 -0400 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=dXZyVBQ7; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 592341E070; Wed, 17 Jun 2026 15:23:47 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.8 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_BL_SPAMCOP_NET, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [IPv6:2620:52:6:3111::32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 7E1011E070 for ; Wed, 17 Jun 2026 15:23:46 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 23FC64BA23D3 for ; Wed, 17 Jun 2026 19:23:45 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 23FC64BA23D3 Authentication-Results: sourceware.org; dkim=fail reason="signature verification failed" (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=dXZyVBQ7 Received: from omta040.useast.a.cloudfilter.net (omta040.useast.a.cloudfilter.net [44.202.169.39]) by sourceware.org (Postfix) with ESMTPS id 87C704BA2E17 for ; Wed, 17 Jun 2026 19:23:17 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 87C704BA2E17 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 87C704BA2E17 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=44.202.169.39 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1781724197; cv=none; b=XTY/uXPqSF4natLAa7+B54Uy/+7wkY+aimP4lM+8L2J91EaAUCZwhBKcMH8amVjo8qsIh/CttkmOioVbJkPXaVtOuoRkktRmEelYtIcFuD7F4pDTOJL6WRIJjKSgS6CztRoQ6LXBX3k2r42u1afPLiokj6yOGUsy13JKAnOePhM= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1781724197; c=relaxed/simple; bh=T8JNxsxbQ9J2h/En8JHVDeuPNbFVisoygztbwTWVSMs=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=IcC0JEqt8zJToWxxFKtQHK/dTDkC50j3rpEUB32fA17TKms9QeLlaf/aMrk+G317MchtzxdqQleIkYoNRDJJwlsvWMcYF5nDuuyq+GW4Y+HEO2M3EpuAHz/fn+vBc3s+ysAvRvXqhMeQn1jNMLorzjoVaparlHWts01+CUVXWXA= ARC-Authentication-Results: i=1; sourceware.org; dkim=policy (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=dXZyVBQ7 reason="signing key too small" DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 87C704BA2E17 Received: from eig-obgw-6002b.ext.cloudfilter.net ([10.0.30.203]) by cmsmtp with ESMTPS id ZlBrwsqO7VGUKZvr2wi0dr; Wed, 17 Jun 2026 19:23:16 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id Zvr0wbuhYfpvWZvr0wiwTP; Wed, 17 Jun 2026 19:23:15 +0000 X-Authority-Analysis: v=2.4 cv=Y6j4sgeN c=1 sm=1 tr=0 ts=6a32f424 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=FelO9ux0wxsA:10 a=ItBw4LHWJt0A:10 a=QyXUC8HyAAAA:8 a=zstS-IiYAAAA:8 a=o7HeB0Ce_4xm66ebnDkA:9 a=4G6NA9xxw8l3yy4pmD5M:22 a=DCx65vhANUyCzuf5D8fC:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=5IHRaVfWYNSH71hNz++7f/8aUReVkoejAz0e4yaC6ww=; b=dXZyVBQ7cw4d0IV/vEDq5IeOk1 +XWCog4669B9aNGkRStwJHnRsHyeI2oJyzmEjT0Z8UtYuiQIgweLkYywao3YBAME4klx2wbyimeSM R7xNvAm9sZdSiMpc1thgReVVs; Received: from 75-166-225-82.hlrn.qwest.net ([75.166.225.82]:60522 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.99.2) (envelope-from ) id 1wZvr0-00000003ACv-1TnE; Wed, 17 Jun 2026 13:23:14 -0600 From: Tom Tromey To: Stephan Rohr Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 1/1] gdb, testsuite: unify 'Switching to thread' message In-Reply-To: <20260616130419.121388-1-stephan.rohr@intel.com> (Stephan Rohr's message of "Tue, 16 Jun 2026 13:04:19 +0000") References: <20260616130419.121388-1-stephan.rohr@intel.com> X-Attribution: Tom Date: Wed, 17 Jun 2026 13:23:09 -0600 Message-ID: <87zf0t3raa.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.225.82 X-Source-L: No X-Exim-ID: 1wZvr0-00000003ACv-1TnE X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-225-82.hlrn.qwest.net (bapiya) [75.166.225.82]:60522 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfOtpGmh4Tt57Z8Gu8wvVvLduWJAQ6+9iNxQU1SOeyZDQ5DrkHY8fBsbNQro8b9luTZQSSAf4A6XozDnjxC/eVrfoZXt+6dFw6/lO/+GUWr0R9vV71uIo Kx23IF8WcrJiwMTGxalGL+jMfWBNS5UMjbd7Ki8J86LOOemlOye8mSBxlKtdkaPZMpCnByV6JWFdYjGbv/Hul/L+YFJd/dzhQV4= X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org >>>>> Stephan Rohr writes: > From: "Rohr, Stephan" > The 'normal_stop ()' function in infrun prints > [Switching to Thread 0x155554dff6c0 (LWP 77976)] > on thread switch. The 'print_selected_thread_frame ()' function > in thread.c prints > [Switching to thread 2 (Thread 0x155554dff6c0 (LWP 96643))] > Ensure consistent output by updating the thread switch message in > 'normal_stop ()'. I'm in favor of uniformity so I'm in favor of the core part of the patch. See below. Also see commit f99be06d where some other things display thread info differently: [New Thread 0x7ffff7cbe6c0 (LWP 1267702) (id 2)] [Thread 0x7ffff6cbd6c0 (LWP 1267703) (id 3) exited] Maybe we ought to make those more uniform as well. You don't have to do this in order to land this patch though. > - -re "^\\\[Switching to Thread\[^\r\n\]+\\\]\r\n" { > + -re "^\\\[Switching to thread\[^\r\n\]+\\\]\r\n" { > + puts "XXX: Consume switching to thread line" > verbose -log "XXX: Consume switching to thread line" > - exp_continue > + fail $gdb_test_name This seems wrong. At least the puts is clearly just for debugging (unclear why the verbose wasn't enough); but I think the 'fail' is a leftover too. Ok with this hunk fixed up. Approved-By: Tom Tromey Tom