Re: [PATCH] gdbsupport: assert upon an unhandled exception in scope_exit

[Tom Tromey <tom@tromey.com>]

>>>>> "Andrew" == Andrew Burgess <aburgess@redhat.com> writes:

Andrew> I was originally going to write ex.message cannot be nullptr as we never
Andrew> guard calls to ex.what anywhere else in GDB.  But after checking, it is
Andrew> possible to create a gdb_exception with a nullptr message.  I guess in
Andrew> practice though this never happens as any exception thrown vie
Andrew> error(...) will always have been give a message, you'd have to work hard
Andrew> to throw an exception without a message.

Andrew> I wonder if we should make the what() function handle this case?

Yeah, I think we should not allow making a message-less gdb exception.
IIUC.

Tom