[PATCH] gdbsupport: assert upon an unhandled exception in scope_exit

[Stephan Rohr <stephan.rohr@intel.com>]

From: Mihails Strasuns <mihails.strasuns@intel.com>

Add a catch-all statement in a scope_exit_base class destructor to turn
any unhandled exception from "POLICY::on_exit ()" into a GDB assertion -
any such case is a programming error, because it is not legal in C++ to
throw from a destructor.

Co-Authored-By: Rohr, Stephan <stephan.rohr@intel.com>
---
 gdbsupport/scope-exit.h | 12 +++++++++++-
 1 file changed, 11 insertions(+), 1 deletion(-)

diff --git a/gdbsupport/scope-exit.h b/gdbsupport/scope-exit.h
index c90b3194cb5..1dfdb1ef695 100644
--- a/gdbsupport/scope-exit.h
+++ b/gdbsupport/scope-exit.h
@@ -68,7 +68,17 @@ class scope_exit_base : private POLICY
   ~scope_exit_base ()
   {
     if (!m_released)
-      POLICY::on_exit ();
+      {
+	try
+	  {
+	    POLICY::on_exit ();
+	  }
+	catch (const gdb_exception &ex)
+	  {
+	    gdb_assert_not_reached ("unhandled exception in scope exit: %s",
+				    ex.message != nullptr ? ex.what () : "");
+	  }
+      }
   }
 
   DISABLE_COPY_AND_ASSIGN (scope_exit_base);
-- 
2.43.0

________________________________________
Intel Deutschland GmbH 

Registered Address: Dornacher Strasse 1, 85622 Feldkirchen, Germany 

Tel: +49 (89) 99143-0 

www.intel.de 

Managing Directors: Candice Moore, Jeffrey Schneiderman, Ramachandran Sitaraman

Chairperson of the Supervisory Board: Sonja Pierer

Registered Seat: Munich Commercial Register B: Amtsgericht Munich HRB 186928

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.