From: Tom Tromey <tromey@redhat.com>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 01/10] change gdb to refcount bfd everywhere
Date: Mon, 23 Jul 2012 15:01:00 -0000 [thread overview]
Message-ID: <87y5mar06o.fsf@fleche.redhat.com> (raw)
In-Reply-To: <877gtusfb7.fsf@fleche.redhat.com> (Tom Tromey's message of "Mon, 23 Jul 2012 08:49:32 -0600")
Jan> There was some conclusion on gdb-patches to make happy both people
Jan> wanting comments in *.c and people wanting comments in *.h and to
Jan> prevent duplication of the same comment in both *.c and *.h which
Jan> leads to stale invalid comments in one of the files to put the
Jan> comment only in *.h file and in the *.c file state: /* See
Jan> gdb_bfd.h. */ You even use it at various functions in gdb_bfd.c,
Jan> just not for gdb_bfd_ref and gdb_bfd_unref.
Tom> I'll fix it.
Here's the patch.
Tom
2012-07-23 Tom Tromey <tromey@redhat.com>
* gdb_bfd.c (gdb_bfd_ref, gdb_bfd_unref): Fix comment.
Index: gdb_bfd.c
===================================================================
RCS file: /cvs/src/src/gdb/gdb_bfd.c,v
retrieving revision 1.6
diff -u -r1.6 gdb_bfd.c
--- gdb_bfd.c 23 Jul 2012 14:57:54 -0000 1.6
+++ gdb_bfd.c 23 Jul 2012 15:00:55 -0000
@@ -218,7 +218,7 @@
return ret;
}
-/* Add reference to ABFD. Returns ABFD. */
+/* See gdb_bfd.h. */
void
gdb_bfd_ref (struct bfd *abfd)
@@ -242,7 +242,7 @@
bfd_usrdata (abfd) = gdata;
}
-/* Unreference and possibly close ABFD. */
+/* See gdb_bfd.h. */
void
gdb_bfd_unref (struct bfd *abfd)
next prev parent reply other threads:[~2012-07-23 15:01 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-18 19:32 Tom Tromey
2012-07-19 14:18 ` Jan Kratochvil
2012-07-19 20:58 ` Tom Tromey
2012-07-20 16:37 ` Tom Tromey
2012-07-20 18:11 ` Jan Kratochvil
2012-07-20 16:37 ` Tom Tromey
2012-07-23 8:54 ` Jan Kratochvil
2012-07-23 9:06 ` Jan Kratochvil
2012-07-23 15:23 ` Tom Tromey
2012-07-23 15:25 ` Tom Tromey
2012-07-24 13:17 ` Jan Kratochvil
2012-07-24 19:52 ` Tom Tromey
2012-07-24 20:27 ` Eli Zaretskii
2012-07-25 14:25 ` Tom Tromey
2012-07-25 14:29 ` Jan Kratochvil
2012-07-25 14:52 ` Tom Tromey
2012-07-25 14:55 ` Jan Kratochvil
2012-07-25 15:44 ` Tom Tromey
2012-07-25 15:37 ` Eli Zaretskii
2012-07-25 11:57 ` Jan Kratochvil
2012-07-23 14:52 ` Tom Tromey
2012-07-23 18:54 ` Tom Tromey
2012-07-23 19:02 ` Jan Kratochvil
2012-07-23 19:08 ` Tom Tromey
2012-07-22 19:00 ` Jan Kratochvil
2012-07-23 14:49 ` Tom Tromey
2012-07-23 15:01 ` Tom Tromey [this message]
2012-07-23 15:03 ` Tom Tromey
2012-07-20 16:31 ` Tom Tromey
2012-07-20 18:10 ` Jan Kratochvil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y5mar06o.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=jan.kratochvil@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox