From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30306 invoked by alias); 23 Jul 2012 15:01:52 -0000 Received: (qmail 30259 invoked by uid 22791); 23 Jul 2012 15:01:50 -0000 X-SWARE-Spam-Status: No, hits=-6.5 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 23 Jul 2012 15:01:36 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q6NF1aWG003264 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 23 Jul 2012 11:01:36 -0400 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id q6NF1Z68007672 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Mon, 23 Jul 2012 11:01:35 -0400 From: Tom Tromey To: Jan Kratochvil Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 01/10] change gdb to refcount bfd everywhere References: <87vchk3lxs.fsf@fleche.redhat.com> <20120719141750.GB23801@host2.jankratochvil.net> <877gtzxyck.fsf@fleche.redhat.com> <20120722190009.GA25479@host2.jankratochvil.net> <877gtusfb7.fsf@fleche.redhat.com> Date: Mon, 23 Jul 2012 15:01:00 -0000 In-Reply-To: <877gtusfb7.fsf@fleche.redhat.com> (Tom Tromey's message of "Mon, 23 Jul 2012 08:49:32 -0600") Message-ID: <87y5mar06o.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-07/txt/msg00449.txt.bz2 Jan> There was some conclusion on gdb-patches to make happy both people Jan> wanting comments in *.c and people wanting comments in *.h and to Jan> prevent duplication of the same comment in both *.c and *.h which Jan> leads to stale invalid comments in one of the files to put the Jan> comment only in *.h file and in the *.c file state: /* See Jan> gdb_bfd.h. */ You even use it at various functions in gdb_bfd.c, Jan> just not for gdb_bfd_ref and gdb_bfd_unref. Tom> I'll fix it. Here's the patch. Tom 2012-07-23 Tom Tromey * gdb_bfd.c (gdb_bfd_ref, gdb_bfd_unref): Fix comment. Index: gdb_bfd.c =================================================================== RCS file: /cvs/src/src/gdb/gdb_bfd.c,v retrieving revision 1.6 diff -u -r1.6 gdb_bfd.c --- gdb_bfd.c 23 Jul 2012 14:57:54 -0000 1.6 +++ gdb_bfd.c 23 Jul 2012 15:00:55 -0000 @@ -218,7 +218,7 @@ return ret; } -/* Add reference to ABFD. Returns ABFD. */ +/* See gdb_bfd.h. */ void gdb_bfd_ref (struct bfd *abfd) @@ -242,7 +242,7 @@ bfd_usrdata (abfd) = gdata; } -/* Unreference and possibly close ABFD. */ +/* See gdb_bfd.h. */ void gdb_bfd_unref (struct bfd *abfd)