From: Tom Tromey <tromey@redhat.com>
To: Yao Qi <yao@codesourcery.com>
Cc: <gdb-patches@sourceware.org>
Subject: Re: [committed]: [PATCH 0/4] Fix member pointer bugs
Date: Wed, 28 Nov 2012 16:37:00 -0000 [thread overview]
Message-ID: <87y5hladko.fsf@fleche.redhat.com> (raw)
In-Reply-To: <50B62A3C.2060202@codesourcery.com> (Yao Qi's message of "Wed, 28 Nov 2012 23:14:04 +0800")
>>>>> "Yao" == Yao Qi <yao@codesourcery.com> writes:
Yao> No, I didn't see this warning before. I'll have a look.
This fixes it for me. What do you think? I mean aside from the line
break problem...
Tom
diff --git a/gdb/eval.c b/gdb/eval.c
index 55582e0..faad9e3 100644
--- a/gdb/eval.c
+++ b/gdb/eval.c
@@ -1410,7 +1410,7 @@ evaluate_subexp_standard (struct type *expect_type,
mem_offset = value_as_long (arg1);
- arg1 = value_from_pointer (type_ptr,
+ arg1 = value_from_pointer (lookup_pointer_type (TYPE_TARGET_TYPE (type)),
value_as_long (arg2) + mem_offset);
arg1 = value_ind (arg1);
tem = 1;
next prev parent reply other threads:[~2012-11-28 16:37 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-22 7:32 Yao Qi
2012-11-22 7:32 ` [PATCH 1/4] testcase - pointer to member function Yao Qi
2012-11-26 16:32 ` Tom Tromey
2012-11-22 7:33 ` [PATCH 2/4] factor code Yao Qi
2012-11-22 7:33 ` [PATCH 4/4] Handle TYPE_CODE_MEMBERPTR Yao Qi
2012-11-22 8:07 ` Yao Qi
2012-11-26 16:42 ` Tom Tromey
2012-11-22 7:33 ` [PATCH 3/4] Use TYPE_TARGET_TYPE Yao Qi
2012-11-26 16:41 ` Tom Tromey
2012-11-27 8:03 ` [committed]: [PATCH 0/4] Fix member pointer bugs Yao Qi
2012-11-28 14:47 ` Tom Tromey
2012-11-28 15:14 ` Yao Qi
2012-11-28 16:37 ` Tom Tromey [this message]
2012-11-29 7:46 ` Yao Qi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y5hladko.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=yao@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox