From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10616 invoked by alias); 28 Nov 2012 16:37:42 -0000 Received: (qmail 10438 invoked by uid 22791); 28 Nov 2012 16:37:38 -0000 X-SWARE-Spam-Status: No, hits=-6.7 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 28 Nov 2012 16:37:29 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id qASGbSSH007210 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 28 Nov 2012 11:37:28 -0500 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id qASGbRqX024411 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Wed, 28 Nov 2012 11:37:27 -0500 From: Tom Tromey To: Yao Qi Cc: Subject: Re: [committed]: [PATCH 0/4] Fix member pointer bugs References: <1353569539-744-1-git-send-email-yao@codesourcery.com> <50B473AC.5070604@codesourcery.com> <8738ztbx9b.fsf@fleche.redhat.com> <50B62A3C.2060202@codesourcery.com> Date: Wed, 28 Nov 2012 16:37:00 -0000 In-Reply-To: <50B62A3C.2060202@codesourcery.com> (Yao Qi's message of "Wed, 28 Nov 2012 23:14:04 +0800") Message-ID: <87y5hladko.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-11/txt/msg00815.txt.bz2 >>>>> "Yao" == Yao Qi writes: Yao> No, I didn't see this warning before. I'll have a look. This fixes it for me. What do you think? I mean aside from the line break problem... Tom diff --git a/gdb/eval.c b/gdb/eval.c index 55582e0..faad9e3 100644 --- a/gdb/eval.c +++ b/gdb/eval.c @@ -1410,7 +1410,7 @@ evaluate_subexp_standard (struct type *expect_type, mem_offset = value_as_long (arg1); - arg1 = value_from_pointer (type_ptr, + arg1 = value_from_pointer (lookup_pointer_type (TYPE_TARGET_TYPE (type)), value_as_long (arg2) + mem_offset); arg1 = value_ind (arg1); tem = 1;