From: Tom Tromey <tromey@redhat.com>
To: Phil Muldoon <pmuldoon@redhat.com>
Cc: "gdb-patches\@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [patch] Convert frame_stash to a hash table
Date: Thu, 16 May 2013 19:07:00 -0000 [thread overview]
Message-ID: <87y5beyc8u.fsf@fleche.redhat.com> (raw)
In-Reply-To: <51952D8B.3090100@redhat.com> (Phil Muldoon's message of "Thu, 16 May 2013 20:03:39 +0100")
>>>>> "Phil" == Phil Muldoon <pmuldoon@redhat.com> writes:
Phil> + gdb_assert (!f_id.stack_addr_p || !f_id.code_addr_p
Phil> + || !f_id.special_addr_p);
I think those "!"s should not be there.
You want to ensure that one of these is true.
Tom
next prev parent reply other threads:[~2013-05-16 19:07 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-16 13:09 Phil Muldoon
2013-05-16 13:42 ` Tom Tromey
2013-05-16 14:17 ` Phil Muldoon
2013-05-16 18:16 ` Tom Tromey
2013-05-16 19:03 ` Phil Muldoon
2013-05-16 19:07 ` Tom Tromey [this message]
2013-05-16 19:27 ` Phil Muldoon
2013-05-16 20:23 ` Tom Tromey
2013-05-17 8:39 ` Phil Muldoon
2013-05-16 13:42 ` Pedro Alves
2013-05-16 13:50 ` Phil Muldoon
2013-05-16 14:23 ` Pedro Alves
2013-05-16 14:27 ` Phil Muldoon
2013-05-16 14:41 ` Pedro Alves
2013-05-16 14:54 ` Phil Muldoon
2013-05-16 18:44 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y5beyc8u.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=pmuldoon@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox