Re: [patch] Convert frame_stash to a hash table

[Pedro Alves <palves@redhat.com>]

On 05/16/2013 03:23 PM, Pedro Alves wrote:

> I'd expected that a simple filter (like I imagine yours was)
> you'd not see any performance hit.

For the archives -- Phil and I spent a bit investigating tihs.
This expectation was just too naive.
The way the current frame stash is managed today (the last
frame get_frame_id is called on) lends itself to all sorts
of random places in the frame code where the stash happens
to flip to the wrong frame, or cases where we'd expect
the stash to be set but isn't (e.g., frapy_older
leaves without the stash set to the older frame).  This
is just too fragile for this use case.  Let's move on with the
new hash stash and be done with it.

Thanks,
-- 
Pedro Alves