From: Tom Tromey <tom@tromey.com>
To: Joel Brobecker <brobecker@adacore.com>
Cc: Tom Tromey <tom@tromey.com>, gdb-patches@sourceware.org
Subject: Re: [RFA v2 4/4] Handle DW_TAG_variant_part and DW_TAG_variant
Date: Mon, 26 Feb 2018 16:16:00 -0000 [thread overview]
Message-ID: <87y3jfpvyh.fsf@tromey.com> (raw)
In-Reply-To: <20180226065620.z6dzyzrlr72kylnn@adacore.com> (Joel Brobecker's message of "Mon, 26 Feb 2018 10:56:20 +0400")
>>>>> "Joel" == Joel Brobecker <brobecker@adacore.com> writes:
>> 2018-02-22 Tom Tromey <tom@tromey.com>
>>
>> * dwarf2read.c (struct variant_field): New.
>> (struct nextfield) <variant>: New field.
>> (dwarf2_add_field): Handle DW_TAG_variant_part.
>> (dwarf2_attach_fields_to_type): Attach a discriminant_info to a
>> discriminated union.
Joel> Looks good to me, Tom. Thanks!
Thanks for the reviews. I've updated the patches. Patch #4 needed a
minor adjustment to the new complaints to account for the recent 64-bit
sect_offset change.
Tom
next prev parent reply other threads:[~2018-02-26 16:16 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-22 20:30 [RFA v2 0/4] variants and variant parts Tom Tromey
2018-02-22 20:30 ` [RFA v2 2/4] Initial support for " Tom Tromey
2018-02-26 6:49 ` Joel Brobecker
2018-02-22 20:30 ` [RFA v2 4/4] Handle DW_TAG_variant_part and DW_TAG_variant Tom Tromey
2018-02-26 6:56 ` Joel Brobecker
2018-02-26 16:16 ` Tom Tromey [this message]
2018-02-22 20:30 ` [RFA v2 1/4] Sign-extend non-bit-fields in unpack_bits_as_long Tom Tromey
2018-02-26 6:45 ` Joel Brobecker
2018-02-22 20:30 ` [RFA v2 3/4] Convert Rust to use discriminated unions Tom Tromey
2018-02-26 6:50 ` Joel Brobecker
2018-02-27 23:23 ` Pedro Alves
2018-02-28 0:23 ` Tom Tromey
2018-04-10 20:36 ` -readnow crash Rust regression [Re: [RFA v2 3/4] Convert Rust to use discriminated unions] Jan Kratochvil
2018-04-11 2:52 ` Tom Tromey
2018-04-11 7:04 ` Jan Kratochvil
2018-04-11 19:49 ` Tom Tromey
2018-04-12 18:10 ` Tom Tromey
2018-04-12 18:45 ` Keith Seitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y3jfpvyh.fsf@tromey.com \
--to=tom@tromey.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox