From: Joel Brobecker <brobecker@adacore.com>
To: Tom Tromey <tom@tromey.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFA v2 2/4] Initial support for variant parts
Date: Mon, 26 Feb 2018 06:49:00 -0000 [thread overview]
Message-ID: <20180226064918.trbwkkkrhitv6nyb@adacore.com> (raw)
In-Reply-To: <20180222203018.23551-3-tom@tromey.com>
On Thu, Feb 22, 2018 at 01:30:16PM -0700, Tom Tromey wrote:
> This adds some initial support for variant parts to gdbtypes.h. A
> variant part is represented as a union. The union has a flag
> indicating that it has a discriminant, and information about the
> discriminant is attached using the dynamic property system.
>
> 2018-02-22 Tom Tromey <tom@tromey.com>
>
> * value.h (value_union_variant): Declare.
> * valops.c (value_union_variant): New function.
> * gdbtypes.h (TYPE_FLAG_DISCRIMINATED_UNION): New macro.
> (struct discriminant_info): New.
> (enum dynamic_prop_node_kind) <DYN_PROP_DISCRIMINATED>: New
> enumerator.
> (struct main_type) <flag_discriminated_union>: New field.
OK, with just one minor typo below...
> + /* Compute the discriminant. Note that unpack_field_as_long handles
> + sign extension when necessary, as does the DWARF reader -- so
> + signed discriminants will be handled correct despite the use of
correct -> correctly
Thanks!
--
Joel
prev parent reply other threads:[~2018-02-26 6:49 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-22 20:30 [RFA v2 0/4] variants and " Tom Tromey
2018-02-22 20:30 ` [RFA v2 3/4] Convert Rust to use discriminated unions Tom Tromey
2018-02-26 6:50 ` Joel Brobecker
2018-02-27 23:23 ` Pedro Alves
2018-02-28 0:23 ` Tom Tromey
2018-04-10 20:36 ` -readnow crash Rust regression [Re: [RFA v2 3/4] Convert Rust to use discriminated unions] Jan Kratochvil
2018-04-11 2:52 ` Tom Tromey
2018-04-11 7:04 ` Jan Kratochvil
2018-04-11 19:49 ` Tom Tromey
2018-04-12 18:10 ` Tom Tromey
2018-04-12 18:45 ` Keith Seitz
2018-02-22 20:30 ` [RFA v2 1/4] Sign-extend non-bit-fields in unpack_bits_as_long Tom Tromey
2018-02-26 6:45 ` Joel Brobecker
2018-02-22 20:30 ` [RFA v2 4/4] Handle DW_TAG_variant_part and DW_TAG_variant Tom Tromey
2018-02-26 6:56 ` Joel Brobecker
2018-02-26 16:16 ` Tom Tromey
2018-02-22 20:30 ` [RFA v2 2/4] Initial support for variant parts Tom Tromey
2018-02-26 6:49 ` Joel Brobecker [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180226064918.trbwkkkrhitv6nyb@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox