From: Tom Tromey <tom@tromey.com>
To: Pedro Alves <palves@redhat.com>
Cc: Tom Tromey <tom@tromey.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH 8/9] Avoid undefined behavior in expression dumping
Date: Wed, 29 Aug 2018 00:27:00 -0000 [thread overview]
Message-ID: <87y3cqvwyz.fsf@tromey.com> (raw)
In-Reply-To: <939ad729-dc06-5f8f-e9a3-5a9b40af80ab@redhat.com> (Pedro Alves's message of "Tue, 28 Aug 2018 19:48:51 +0100")
>>>>> "Pedro" == Pedro Alves <palves@redhat.com> writes:
Pedro> Could you include before/after example output?
It'll be in the next revision.
>> const char *
>> op_name (struct expression *exp, enum exp_opcode opcode)
>> {
>> + if (opcode >= OP_UNUSED_LAST)
>> + {
>> + char *cell = get_print_cell ();
>> + xsnprintf (cell, PRINT_CELL_SIZE, "unknown opcode: %d", int (opcode));
Pedro> If the underlying type is unsigned, what is the rationale for
Pedro> printing it as signed?
Thinko.
Tom
next prev parent reply other threads:[~2018-08-29 0:27 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-27 14:57 [PATCH 0/9] Add UBSan to the build Tom Tromey
2018-08-27 14:57 ` [PATCH 1/9] Do not pass NULL to memcpy Tom Tromey
2018-08-27 19:12 ` Simon Marchi
2018-08-28 22:40 ` Tom Tromey
2018-08-27 14:57 ` [PATCH 5/9] Avoid undefined behavior in parse_number Tom Tromey
2018-08-27 14:57 ` [PATCH 2/9] Use unsigned as base type for some enums Tom Tromey
2018-08-27 19:22 ` Simon Marchi
2018-08-27 20:22 ` Tom Tromey
2018-08-27 21:26 ` Simon Marchi
2018-08-28 18:54 ` Pedro Alves
2018-08-28 22:42 ` Tom Tromey
2018-08-29 0:01 ` Tom Tromey
2018-08-27 14:57 ` [PATCH 7/9] Avoid undefined behavior in ada_operator_length Tom Tromey
2018-08-27 14:57 ` [PATCH 3/9] Avoid undefined behavior in extract_integer Tom Tromey
2018-08-28 18:39 ` Pedro Alves
2018-08-29 0:11 ` Tom Tromey
2018-08-27 14:57 ` [PATCH 6/9] Avoid undefined behavior in read_signed_leb128 Tom Tromey
2018-08-27 14:59 ` [PATCH 9/9] Add --enable-ubsan Tom Tromey
2018-08-27 14:59 ` [PATCH 4/9] Avoid undefined behavior in read_subrange_type Tom Tromey
2018-08-27 14:59 ` [PATCH 8/9] Avoid undefined behavior in expression dumping Tom Tromey
2018-08-28 18:49 ` Pedro Alves
2018-08-29 0:27 ` Tom Tromey [this message]
2018-08-28 19:03 ` [PATCH 0/9] Add UBSan to the build Pedro Alves
2018-08-29 0:45 ` Tom Tromey
2018-08-30 18:41 ` Pedro Alves
2018-08-30 18:56 ` Tom Tromey
2018-08-30 19:06 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y3cqvwyz.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox