From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 107073 invoked by alias); 29 Aug 2018 00:27:27 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 107062 invoked by uid 89); 29 Aug 2018 00:27:26 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: gateway23.websitewelcome.com Received: from gateway23.websitewelcome.com (HELO gateway23.websitewelcome.com) (192.185.50.250) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 29 Aug 2018 00:27:25 +0000 Received: from cm10.websitewelcome.com (cm10.websitewelcome.com [100.42.49.4]) by gateway23.websitewelcome.com (Postfix) with ESMTP id F10F777EA for ; Tue, 28 Aug 2018 19:27:23 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id uoK6fFeQlBcCXuoKIfjzyL; Tue, 28 Aug 2018 19:27:23 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=KIOI5Abdh7BReVRVbkrHFBcezRTn3ktAgTfrDGD8Ol8=; b=hWHqtBiTllc557FHMmKFL2Kbtb 9hFBJNy3YVbpp/NumMv9sKCMGyocjyGBBx6u8W9A4yXNKx7+faePePVCQklqH7B3BC4CP0TJujy9h ePgRNE/k6jVxYm20PAObCBIw2; Received: from 75-166-85-72.hlrn.qwest.net ([75.166.85.72]:45754 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1fuoK5-003XWF-PA; Tue, 28 Aug 2018 19:27:01 -0500 From: Tom Tromey To: Pedro Alves Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH 8/9] Avoid undefined behavior in expression dumping References: <20180827145620.11055-1-tom@tromey.com> <20180827145620.11055-9-tom@tromey.com> <939ad729-dc06-5f8f-e9a3-5a9b40af80ab@redhat.com> Date: Wed, 29 Aug 2018 00:27:00 -0000 In-Reply-To: <939ad729-dc06-5f8f-e9a3-5a9b40af80ab@redhat.com> (Pedro Alves's message of "Tue, 28 Aug 2018 19:48:51 +0100") Message-ID: <87y3cqvwyz.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2018-08/txt/msg00722.txt.bz2 >>>>> "Pedro" == Pedro Alves writes: Pedro> Could you include before/after example output? It'll be in the next revision. >> const char * >> op_name (struct expression *exp, enum exp_opcode opcode) >> { >> + if (opcode >= OP_UNUSED_LAST) >> + { >> + char *cell = get_print_cell (); >> + xsnprintf (cell, PRINT_CELL_SIZE, "unknown opcode: %d", int (opcode)); Pedro> If the underlying type is unsigned, what is the rationale for Pedro> printing it as signed? Thinko. Tom