From: Tom Tromey <tom@tromey.com>
To: Philippe Waroquiers <philippe.waroquiers@skynet.be>
Cc: Tom Tromey <tom@tromey.com>, gdb-patches@sourceware.org
Subject: Re: [PUSHED/OBVIOUS] Re-fix leak in source.c (open_source_file).
Date: Thu, 29 Nov 2018 23:29:00 -0000 [thread overview]
Message-ID: <87y39b79a8.fsf@tromey.com> (raw)
In-Reply-To: <1543533240.4149.9.camel@skynet.be> (Philippe Waroquiers's message of "Fri, 30 Nov 2018 00:14:00 +0100")
>>>>> "Philippe" == Philippe Waroquiers <philippe.waroquiers@skynet.be> writes:
Philippe> Note that after having run all GDB tests under valgrind, I still
Philippe> see some 4K leaks in open_source_file appearing (I suspect)
Philippe> when GDB reloads an executable that has changed.
What are the leaks? I wonder if the "fullname"s in the psymtabs aren't
being freed.
I have been wondering lately if this field should be pulled out into
some separate hash table. This would save a little memory if there are
file names, which seems likely.
Tom
next prev parent reply other threads:[~2018-11-29 23:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20181124115237.8943-1-philippe.waroquiers@skynet.be>
2018-11-29 18:13 ` Tom Tromey
2018-11-29 23:14 ` Philippe Waroquiers
2018-11-29 23:29 ` Tom Tromey [this message]
2018-11-29 23:45 ` Philippe Waroquiers
2018-11-30 16:39 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y39b79a8.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=philippe.waroquiers@skynet.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox