From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 48620 invoked by alias); 29 Nov 2018 23:29:08 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 48607 invoked by uid 89); 29 Nov 2018 23:29:07 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=pulled, Hx-languages-length:614, H*f:sk:1543533, H*i:sk:1543533 X-HELO: gateway34.websitewelcome.com Received: from gateway34.websitewelcome.com (HELO gateway34.websitewelcome.com) (192.185.148.164) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 29 Nov 2018 23:29:06 +0000 Received: from cm11.websitewelcome.com (cm11.websitewelcome.com [100.42.49.5]) by gateway34.websitewelcome.com (Postfix) with ESMTP id D28441C2359 for ; Thu, 29 Nov 2018 17:29:04 -0600 (CST) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id SVk0gkmxURPojSVk0gt5H9; Thu, 29 Nov 2018 17:29:04 -0600 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=hyD7HV21K8+NVEO4FQYN2SOPWy8d/RvN/5wyDLM0c7g=; b=C3GGvwdy2j7P6yawGS1xsUoH8d MH2kHzVCIPkQhUNgimBYLznuCXeUY9E+sGIEpQdpwIGHruUiZnplSD4ln65L8K18uHMWrxKbLqKip K7UfPmjhtEQXY8aPXrbmGDI/b; Received: from 97-122-190-66.hlrn.qwest.net ([97.122.190.66]:56358 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1gSVk0-0024OJ-KW; Thu, 29 Nov 2018 17:29:04 -0600 From: Tom Tromey To: Philippe Waroquiers Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PUSHED/OBVIOUS] Re-fix leak in source.c (open_source_file). References: <20181124115237.8943-1-philippe.waroquiers@skynet.be> <87ftvjbvmc.fsf@tromey.com> <1543533240.4149.9.camel@skynet.be> Date: Thu, 29 Nov 2018 23:29:00 -0000 In-Reply-To: <1543533240.4149.9.camel@skynet.be> (Philippe Waroquiers's message of "Fri, 30 Nov 2018 00:14:00 +0100") Message-ID: <87y39b79a8.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2018-11/txt/msg00561.txt.bz2 >>>>> "Philippe" == Philippe Waroquiers writes: Philippe> Note that after having run all GDB tests under valgrind, I still Philippe> see some 4K leaks in open_source_file appearing (I suspect) Philippe> when GDB reloads an executable that has changed. What are the leaks? I wonder if the "fullname"s in the psymtabs aren't being freed. I have been wondering lately if this field should be pulled out into some separate hash table. This would save a little memory if there are file names, which seems likely. Tom