Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tromey@adacore.com>
To: Pedro Alves <palves@redhat.com>
Cc: Tom Tromey <tromey@adacore.com>,  gdb-patches@sourceware.org
Subject: Re: [RFC] Don't show "display"s twice in MI
Date: Wed, 13 Mar 2019 15:17:00 -0000	[thread overview]
Message-ID: <87y35ix0pv.fsf@tromey.com> (raw)
In-Reply-To: <0a23b883-9c80-a9e2-1e3e-3aa8c0b0ce13@redhat.com> (Pedro Alves's	message of "Wed, 13 Mar 2019 15:04:23 +0000")

>>>>> "Pedro" == Pedro Alves <palves@redhat.com> writes:

>> Probably we shouldn't print the displays in that case, just to keep
>> things simple, respecting should_print_stop_to_console, but not 100%
>> sure.

Pedro> So your patch makes GDB not do the displays in the
Pedro> -exec-step/-exec-next case, which is the solution I was
Pedro> leaning to above too, even though I'm not 100% sure about it.

I'm not 100% sure either.

We could have a more complicated patch that arranges for do_displays to
be called just once, no matter what decision is made.  Maybe this would
be better?

I originally thought it was somewhat odd to deal with displays in an MI
stepping situation -- MI clients presumably would use varobj.  But,
really the scenario is that the MI client provides a console, the user
types "display ...", and then debugs some more.  I suppose the way that
the "next" is done wouldn't matter to the user?

Tom


  reply	other threads:[~2019-03-13 15:17 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-12 19:03 Tom Tromey
2019-03-12 21:26 ` Simon Marchi
2019-03-13 15:04 ` Pedro Alves
2019-03-13 15:17   ` Tom Tromey [this message]
2019-03-13 15:50     ` Pedro Alves
2019-03-13 21:02       ` Tom Tromey
2019-03-19 17:46         ` Pedro Alves
2019-03-13 18:41     ` André Pönitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87y35ix0pv.fsf@tromey.com \
    --to=tromey@adacore.com \
    --cc=gdb-patches@sourceware.org \
    --cc=palves@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox