From: Pedro Alves <palves@redhat.com>
To: Tom Tromey <tromey@adacore.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFC] Don't show "display"s twice in MI
Date: Tue, 19 Mar 2019 17:46:00 -0000 [thread overview]
Message-ID: <333a055c-1174-c5c0-f809-8fc89c991f2c@redhat.com> (raw)
In-Reply-To: <87wol2h4iy.fsf@tromey.com>
On 03/13/2019 09:02 PM, Tom Tromey wrote:
>>>>>> "Pedro" == Pedro Alves <palves@redhat.com> writes:
>
> Pedro> Maybe we could simply move the do_display call elsewhere?
>
> There are several spots that call print_stop_event, so instead of that,
> I just added a way for the caller to suppress the displays.
>
> I also addressed your other comments and tried to tighten the test case
> a bit.
>
> Let me know what you think.
I think it looks good, thanks.
Pedro Alves
next prev parent reply other threads:[~2019-03-19 17:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-12 19:03 Tom Tromey
2019-03-12 21:26 ` Simon Marchi
2019-03-13 15:04 ` Pedro Alves
2019-03-13 15:17 ` Tom Tromey
2019-03-13 15:50 ` Pedro Alves
2019-03-13 21:02 ` Tom Tromey
2019-03-19 17:46 ` Pedro Alves [this message]
2019-03-13 18:41 ` André Pönitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=333a055c-1174-c5c0-f809-8fc89c991f2c@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=tromey@adacore.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox