From: Tom Tromey <tom@tromey.com>
To: Tom de Vries <tdevries@suse.de>
Cc: Tom Tromey <tom@tromey.com>,
Gary Benson via Gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH] KFAIL variable-length array tests which fail with Clang
Date: Fri, 20 Nov 2020 08:50:03 -0700 [thread overview]
Message-ID: <87y2iwgh90.fsf@tromey.com> (raw)
In-Reply-To: <0a3f590c-2a76-e470-136f-e8f88aef1d17@suse.de> (Tom de Vries's message of "Thu, 19 Nov 2020 23:53:15 +0100")
>>>>> "Tom" == Tom de Vries <tdevries@suse.de> writes:
Tom> + gdb_byte last = block->data[block->size - 1];
Tom> + baton->locexpr.is_reference
Tom> + = !(last == DW_OP_stack_value || last == DW_OP_implicit_value);
I don't really understand the is_reference stuff, but my first reaction
is that it must be incorrect somehow.
Anyway, gdb can't do this sort of check. It will fail if the expression
has a different shape, which is completely allowed by the spec.
Tom
next prev parent reply other threads:[~2020-11-20 15:50 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-16 17:17 Gary Benson via Gdb-patches
2020-11-18 16:14 ` Tom Tromey
2020-11-19 22:53 ` Tom de Vries
2020-11-20 15:15 ` [PATCH][gdb/symtab] Fix gdb.base/vla-optimized-out.exp with clang Tom de Vries
2020-11-21 17:16 ` [gdb/testsuite] Add clang xfail in gdb.base/vla-ptr.exp Tom de Vries
2020-11-20 15:50 ` Tom Tromey [this message]
2020-11-20 16:30 ` [PATCH] KFAIL variable-length array tests which fail with Clang Tom de Vries
2020-11-20 16:51 ` Tom Tromey
2020-11-23 10:34 ` [PATCH][gdb/symtab] Fix gdb.base/vla-optimized-out.exp with clang Tom de Vries
2020-11-25 14:50 ` Gary Benson via Gdb-patches
2020-11-25 15:25 ` Gary Benson via Gdb-patches
2020-11-25 20:05 ` Tom de Vries
2020-11-26 10:10 ` Gary Benson via Gdb-patches
2020-11-30 12:51 ` [committed][PATCH][gdb/symtab] " Tom de Vries
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y2iwgh90.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=tdevries@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox