From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 7rH3GLDlt1/0aQAAWB0awg (envelope-from ) for ; Fri, 20 Nov 2020 10:50:08 -0500 Received: by simark.ca (Postfix, from userid 112) id 5ADA01F08B; Fri, 20 Nov 2020 10:50:08 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: * X-Spam-Status: No, score=1.6 required=5.0 tests=DKIM_SIGNED,MAILING_LIST_MULTI, RCVD_IN_BL_SPAMCOP_NET,RDNS_NONE,T_DKIM_INVALID,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.2 Received: from sourceware.org (unknown [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 0759C1E58F for ; Fri, 20 Nov 2020 10:50:08 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 87E1D393BC33; Fri, 20 Nov 2020 15:50:07 +0000 (GMT) Received: from gateway33.websitewelcome.com (gateway33.websitewelcome.com [192.185.146.97]) by sourceware.org (Postfix) with ESMTPS id 12D1D393BC09 for ; Fri, 20 Nov 2020 15:50:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 12D1D393BC09 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=tom@tromey.com Received: from cm12.websitewelcome.com (cm12.websitewelcome.com [100.42.49.8]) by gateway33.websitewelcome.com (Postfix) with ESMTP id 875C4608B32 for ; Fri, 20 Nov 2020 09:50:04 -0600 (CST) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id g8fkkUBUtiQiZg8fkkADHh; Fri, 20 Nov 2020 09:50:04 -0600 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=QoTQ3q9JhJQeP8DzYhriqcUyEvJczdrlxoVmGO4hAK8=; b=A1LHNg4DTuojoMjg8iBK/kdFSo Y9CQDWD2JRhDV3iAM1sY2jhIt1oJRL0i/9LkhpibAwNCwMWjdKveimYxKWYXm7fUArkxD4CslA6yN 0gZgro98uN6HGgGvOf+fvsXL+; Received: from 97-122-89-243.hlrn.qwest.net ([97.122.89.243]:39390 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1kg8fk-002q30-7F; Fri, 20 Nov 2020 08:50:04 -0700 From: Tom Tromey To: Tom de Vries Subject: Re: [PATCH] KFAIL variable-length array tests which fail with Clang References: <1605547055-25778-1-git-send-email-gbenson@redhat.com> <87mtzek5fv.fsf@tromey.com> <0a3f590c-2a76-e470-136f-e8f88aef1d17@suse.de> X-Attribution: Tom Date: Fri, 20 Nov 2020 08:50:03 -0700 In-Reply-To: <0a3f590c-2a76-e470-136f-e8f88aef1d17@suse.de> (Tom de Vries's message of "Thu, 19 Nov 2020 23:53:15 +0100") Message-ID: <87y2iwgh90.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.89.243 X-Source-L: No X-Exim-ID: 1kg8fk-002q30-7F X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-89-243.hlrn.qwest.net (murgatroyd) [97.122.89.243]:39390 X-Source-Auth: tom+tromey.com X-Email-Count: 6 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Tom Tromey , Gary Benson via Gdb-patches Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" >>>>> "Tom" == Tom de Vries writes: Tom> + gdb_byte last = block->data[block->size - 1]; Tom> + baton->locexpr.is_reference Tom> + = !(last == DW_OP_stack_value || last == DW_OP_implicit_value); I don't really understand the is_reference stuff, but my first reaction is that it must be incorrect somehow. Anyway, gdb can't do this sort of check. It will fail if the expression has a different shape, which is completely allowed by the spec. Tom