Re: [PATCH] configure.ac: Check for the readline.h explicitly

[Tom Tromey <tom@tromey.com>]

>>>>> ">" == Alexandra Hájková via Gdb-patches <gdb-patches@sourceware.org> writes:

>> From: Alexandra Hájková <ahajkova@redhat.com>
>> When readline development package is missing make fails with
>> "configure: error: system readline is not new enough" which
>> might be confusing. This patch checks for the readline.h explicitly
>> and makes make to warn about the missing package.

Hi.  Thanks for the patch.

>> diff --git a/configure b/configure
>> index 787fcf89100..6a1da1665d8 100755
>> --- a/configure
>> +++ b/configure
>> @@ -755,6 +755,7 @@ infodir
>>  docdir
>>  oldincludedir
>>  includedir
>> +runstatedir
>>  localstatedir
>>  sharedstatedir
>>  sysconfdir

This hunk and some of the other ones may mean that you're regenerating
configure with a distro-modified autoconf rather than the pristine
upstream version.  I'm not sure (maybe someone else did this and your
patch is correcting it, I never remember), but FAOD make sure you're
using the unmodified one.

>>  if test "$with_system_readline" = yes; then
>> +  AC_CHECK_HEADERS(readline/readline.h, [readline_h=yes], [readline_h=no])
>> +  if test "$readline_h" = "no"; then
>> +    AC_MSG_ERROR([readline development packages are probably missing])
>> +  fi

This seems reasonable to me.

Tom