From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id yMBSH0dzlmHfSgAAWB0awg (envelope-from ) for ; Thu, 18 Nov 2021 10:37:43 -0500 Received: by simark.ca (Postfix, from userid 112) id 7E6971F0BF; Thu, 18 Nov 2021 10:37:43 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id CF53D1EDEE for ; Thu, 18 Nov 2021 10:37:41 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 5C72E3857C6A for ; Thu, 18 Nov 2021 15:37:41 +0000 (GMT) Received: from gateway23.websitewelcome.com (gateway23.websitewelcome.com [192.185.48.84]) by sourceware.org (Postfix) with ESMTPS id 211AC3858422 for ; Thu, 18 Nov 2021 15:36:32 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 211AC3858422 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=tromey.com Received: from cm17.websitewelcome.com (cm17.websitewelcome.com [100.42.49.20]) by gateway23.websitewelcome.com (Postfix) with ESMTP id 87CA6A6CE for ; Thu, 18 Nov 2021 09:36:31 -0600 (CST) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id njShmKrl4gm2UnjShmsnHO; Thu, 18 Nov 2021 09:36:31 -0600 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID: In-Reply-To:Date:References:Subject:Cc:To:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=sHNsFM61+UvpXlLub9/Do7Pk6AV7sWuXcAogs/Fv8FY=; b=ehNN6uQe+R+aBWNKt6+kHLPcVM R0nOFlxtYu0Rr//6JClIFOsYjXjG0T93i2qkb+vdsf0EYq5hfBUlB+H/WJE+gNKmGijMWgvW0qAmT 0+w6Z4g2PILvAp7rlqvCuv8hL; Received: from 97-122-68-246.hlrn.qwest.net ([97.122.68.246]:54196 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1mnjSh-003uY2-2U; Thu, 18 Nov 2021 08:36:31 -0700 From: Tom Tromey To: Alexandra =?utf-8?B?SMOhamtvdsOh?= via Gdb-patches Subject: Re: [PATCH] configure.ac: Check for the readline.h explicitly References: <20211118121440.558038-1-ahajkova@redhat.com> X-Attribution: Tom Date: Thu, 18 Nov 2021 08:36:30 -0700 In-Reply-To: <20211118121440.558038-1-ahajkova@redhat.com> ("Alexandra =?utf-8?B?SMOhamtvdsOh?= via Gdb-patches"'s message of "Thu, 18 Nov 2021 13:14:40 +0100") Message-ID: <87y25la329.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.68.246 X-Source-L: No X-Exim-ID: 1mnjSh-003uY2-2U X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-68-246.hlrn.qwest.net (murgatroyd) [97.122.68.246]:54196 X-Source-Auth: tom+tromey.com X-Email-Count: 20 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Alexandra =?utf-8?B?SMOhamtvdsOh?= Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" >>>>> ">" =3D=3D Alexandra H=C3=A1jkov=C3=A1 via Gdb-patches writes: >> From: Alexandra H=C3=A1jkov=C3=A1 >> When readline development package is missing make fails with >> "configure: error: system readline is not new enough" which >> might be confusing. This patch checks for the readline.h explicitly >> and makes make to warn about the missing package. Hi. Thanks for the patch. >> diff --git a/configure b/configure >> index 787fcf89100..6a1da1665d8 100755 >> --- a/configure >> +++ b/configure >> @@ -755,6 +755,7 @@ infodir >> docdir >> oldincludedir >> includedir >> +runstatedir >> localstatedir >> sharedstatedir >> sysconfdir This hunk and some of the other ones may mean that you're regenerating configure with a distro-modified autoconf rather than the pristine upstream version. I'm not sure (maybe someone else did this and your patch is correcting it, I never remember), but FAOD make sure you're using the unmodified one. >> if test "$with_system_readline" =3D yes; then >> + AC_CHECK_HEADERS(readline/readline.h, [readline_h=3Dyes], [readline_h= =3Dno]) >> + if test "$readline_h" =3D "no"; then >> + AC_MSG_ERROR([readline development packages are probably missing]) >> + fi This seems reasonable to me. Tom