From: Tom Tromey via Gdb-patches <gdb-patches@sourceware.org>
To: Tom Tromey via Gdb-patches <gdb-patches@sourceware.org>
Cc: Tom Tromey <tromey@adacore.com>
Subject: Re: [PATCH v7] gdb/python: Add BreakpointLocation type
Date: Thu, 28 Jul 2022 11:47:46 -0600 [thread overview]
Message-ID: <87y1wdi0xp.fsf@tromey.com> (raw)
In-Reply-To: <87r12nslj7.fsf@tromey.com> (Tom Tromey via Gdb-patches's message of "Thu, 14 Jul 2022 10:31:56 -0600")
Simon> +static int find_loc_num_by_location (bp_location* loc);
Tom> I think it would be better to rearrange this so that the forward
Tom> declaration isn't needed.
[...]
I have been wanting this patch for a project I'm working on, and so I
went ahead and made the minor code tweaks needed -- a few formatting
fixups and a couple of missing Python error checks.
I didn't change the documentation, since I feel that may require some
discussion first.
I'm going to check it in now. Thank you for doing this.
Tom
prev parent reply other threads:[~2022-07-28 17:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-07 11:57 Simon Farre via Gdb-patches
2022-07-14 16:31 ` Tom Tromey via Gdb-patches
2022-07-28 17:47 ` Tom Tromey via Gdb-patches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y1wdi0xp.fsf@tromey.com \
--to=gdb-patches@sourceware.org \
--cc=tromey@adacore.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox