Re: [PATCH v2] gdb: testsuite: Test whether PC register is expedited in gdb.server/server-run.exp

[Thiago Jung Bauermann <thiago.bauermann@linaro.org>]

Hello Tom,

Tom Tromey <tom@tromey.com> writes:

>>>>>> Thiago Jung Bauermann <thiago.bauermann@linaro.org> writes:
>
>> One thing GDB always does when the inferior stops is finding out where
>> it's stopped at, by way of querying the value of the program counter
>> register.
>
>> To save a packet round trip, the remote target can send the PC
>> value (often alongside other frequently consulted registers such as the
>> stack pointer) in the stop reply packet as an "expedited register".
>
>> Test that this is actually done for the targets where gdbserver is
>> supposed to.
>
> Thanks for the patch.
>
>> @@ -162,7 +162,7 @@ class register_dump_remote : public register_dump
>>    {
>>      if (regnum < 0)
>>        {
>> -	gdb_printf (file, "Rmt Nr  g/G Offset");
>> +	gdb_printf (file, "Rmt Nr  g/G Offset  Expedited");
>
> Kind of a shame this doesn't use ui-out tables.
>
> Anyway this looks good to me.
> Approved-By: Tom Tromey <tom@tromey.com>

Thank you! Pushed as commit 94aedcf7ea5b.

-- 
Thiago