From: Tom Tromey <tom@tromey.com>
To: Thiago Jung Bauermann <thiago.bauermann@linaro.org>
Cc: gdb-patches@sourceware.org, Andrew Burgess <aburgess@redhat.com>
Subject: Re: [PATCH v2] gdb: testsuite: Test whether PC register is expedited in gdb.server/server-run.exp
Date: Mon, 23 Sep 2024 12:47:42 -0600 [thread overview]
Message-ID: <87ldzijjg1.fsf@tromey.com> (raw)
In-Reply-To: <20240905044202.259066-1-thiago.bauermann@linaro.org> (Thiago Jung Bauermann's message of "Thu, 5 Sep 2024 01:42:02 -0300")
>>>>> Thiago Jung Bauermann <thiago.bauermann@linaro.org> writes:
> One thing GDB always does when the inferior stops is finding out where
> it's stopped at, by way of querying the value of the program counter
> register.
> To save a packet round trip, the remote target can send the PC
> value (often alongside other frequently consulted registers such as the
> stack pointer) in the stop reply packet as an "expedited register".
> Test that this is actually done for the targets where gdbserver is
> supposed to.
Thanks for the patch.
> @@ -162,7 +162,7 @@ class register_dump_remote : public register_dump
> {
> if (regnum < 0)
> {
> - gdb_printf (file, "Rmt Nr g/G Offset");
> + gdb_printf (file, "Rmt Nr g/G Offset Expedited");
Kind of a shame this doesn't use ui-out tables.
Anyway this looks good to me.
Approved-By: Tom Tromey <tom@tromey.com>
Tom
next prev parent reply other threads:[~2024-09-23 18:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-05 4:42 Thiago Jung Bauermann
2024-09-05 5:56 ` Eli Zaretskii
2024-09-23 18:47 ` Tom Tromey [this message]
2024-09-24 18:22 ` Thiago Jung Bauermann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ldzijjg1.fsf@tromey.com \
--to=tom@tromey.com \
--cc=aburgess@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=thiago.bauermann@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox