From: Tom Tromey <tom@tromey.com>
To: Simon Marchi <simark@simark.ca>
Cc: Tom Tromey <tom@tromey.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] Use scoped_fd in linux-nat.c:proc_mem_file
Date: Tue, 18 Mar 2025 05:29:59 -0600 [thread overview]
Message-ID: <87y0x2tw3s.fsf@tromey.com> (raw)
In-Reply-To: <b714c543-afbf-4eed-9d46-e383aada17cd@simark.ca> (Simon Marchi's message of "Mon, 17 Mar 2025 22:16:17 -0400")
>>>>> "Simon" == Simon Marchi <simark@simark.ca> writes:
>> + proc_mem_file (proc_mem_file &&) = default;
>> + proc_mem_file &operator= (proc_mem_file &&) = default;
Simon> Is it really needed to add the move constructor / move assignment
Simon> operator? In fact, I would think that you could remove the
Simon> DISABLE_COPY_AND_ASSIGN, since just having the scoped_fd as a field will
Simon> do the right thing.
I removed both of these.
Tom
prev parent reply other threads:[~2025-03-18 11:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-17 20:55 Tom Tromey
2025-03-18 1:30 ` Kevin Buettner
2025-03-18 2:16 ` Simon Marchi
2025-03-18 11:29 ` Tom Tromey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y0x2tw3s.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=simark@simark.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox